From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: John Naylor <john.naylor@2ndquadrant.com>,
        Amit Langote <amitlangote09@gmail.com>,
        Justin Pryzby <pryzby@telsasoft.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: assert pg_class.relnatts is consistent
In-reply-to: <618.1581706856@sss.pgh.pa.us>
References: <20200214152926.GA7006@alvherre.pgsql>
 <618.1581706856@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Fri, 14 Feb 2020 14:00:56 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8402.1581798355.1@sss.pgh.pa.us>
Date: Sat, 15 Feb 2020 15:25:55 -0500
Message-ID: <8403.1581798355@sss.pgh.pa.us>
Precedence: bulk

I wrote:
> So that leads me to the attached.
> ...
> (I agree with Alvaro's thought of shortening AddDefaultValues,
> but didn't do that here.)

Pushed both of those.  I also did something with the stale comment
that Justin referred to in the initial message (it wasn't really
good practice to try to deal with both things in one thread).

I think we're done here, though maybe the difficulty of finding a clean
way to get genbki.pl to do this suggests that AddDefaultValues needs
to be redesigned.  Not sure what that'd look like.

			regards, tom lane