Received: from makus.postgresql.org (makus.postgresql.org [98.129.198.125])
	by mail.postgresql.org (Postfix) with ESMTP id DAF2E1B6D0F5
	for <pgsql-hackers@postgresql.org>;
	Mon, 25 Jun 2012 22:52:07 -0300 (ADT)
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtp (Exim 4.72)
	(envelope-from <tgl@sss.pgh.pa.us>) id 1SjKwl-0006oA-Do
	for pgsql-hackers@postgresql.org; Tue, 26 Jun 2012 01:52:07 +0000
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.5/8.14.5) with ESMTP id q5Q1pj6j008406;
	Mon, 25 Jun 2012 21:51:46 -0400 (EDT)
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
cc: Robert Haas <robertmhaas@gmail.com>, Fujii Masao <masao.fujii@gmail.com>,
	Andres Freund <andres@2ndquadrant.com>, pgsql-hackers@postgresql.org
Subject: Re: WAL format changes
In-reply-to: <4FE8FDBE.8060901@enterprisedb.com>
References: <4FDA5136.6080206@enterprisedb.com>
	<201206142358.12431.andres@2ndquadrant.com>
	<CA+TgmobG9VWWvLXeK0XOxoWXtza8JTFgSu2eoAtVFucxH6gLBw@mail.gmail.com>
	<4FDF6E8E.4080900@enterprisedb.com>
	<4FE034D0.5070900@enterprisedb.com>
	<CA+TgmoZu=UMKLJDQ5FNRqPnomiGOSdEvzaj_Gg9CJzcPnvuxgQ@mail.gmail.com>
	<4FE73F3F.5040105@enterprisedb.com>
	<CAHGQGwHpdpPrmbq49yOp=zZTsiB+_cnwojRh0Xe9BE1D8fLegg@mail.gmail.com>
	<CAHGQGwGZo-hv2Fxm3LpCsh=mh1T_21mj7MKe35VQyBSZ6PsyVw@mail.gmail.com>
	<CA+TgmoZz=7xRhg389Qj=SwdVCvpK4VSpjJm_yg7WKQuUpk0wjw@mail.gmail.com>
	<4FE8FDBE.8060901@enterprisedb.com>
Comments: In-reply-to Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
	message dated "Tue, 26 Jun 2012 03:09:34 +0300"
Date: Mon, 25 Jun 2012 21:51:45 -0400
Message-ID: <8405.1340675505@sss.pgh.pa.us>
X-Pg-Spam-Score: -1.9 (-)
X-Archive-Number: 201206/1498
X-Sequence-Number: 210338

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
> So I think we should change pg_resetxlog -l option to take a WAL file 
> name as argument, and fix pg_upgrade accordingly.

Seems reasonable I guess.  It's really specifying a starting WAL
location, but only to file granularity, so treating the argument as a
file name is sort of a type cheat but seems convenient.

If we do it that way, we'd better validate that the argument is a legal
WAL file name, so as to catch any cases where somebody tries to do it
old-style.

BTW, does pg_resetxlog's logic for setting the default -l value (from
scanning pg_xlog to find the largest existing file name) still work?

			regards, tom lane