Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jNBAa-00053s-7h for pgsql-hackers@arkaria.postgresql.org; Sat, 11 Apr 2020 08:07:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jNBAX-0000cL-R5 for pgsql-hackers@arkaria.postgresql.org; Sat, 11 Apr 2020 08:07:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jNBAW-0000aN-M6 for pgsql-hackers@lists.postgresql.org; Sat, 11 Apr 2020 08:07:13 +0000 Received: from [66.111.4.27] (helo=out3-smtp.messagingengine.com) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jNBAO-0004le-Vx for pgsql-hackers@postgresql.org; Sat, 11 Apr 2020 08:07:11 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E75055C0227; Sat, 11 Apr 2020 04:06:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 11 Apr 2020 04:06:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=995bS5b3vE6RZJnyZZeREKd3ReVFZq2VJYtB3qw34 JU=; b=t6WehsOVcf7NgXD5i4XwvzWWYveISiDRplLieEGXObDxC4HpA+QPTKWUC o+cRz/+1xt3wsP1RapYR6ZbVIy1ECc1SwEXUanpK9+opdCtxpk/4z8PFvoWkBe9d 0YpI2j8/3F23v7t9K9emYvPsJIw0yt+TSdyJ1QU/xkbamkNMMOIct86fr/4pGRkZ 7/XLnkOwLFn9rnNOgpceXCm1D5JyEk9RxdxoKuYcvlc953OdFiHJqXeDbDchr6Ys 3773fdK7i8IQA21NjySPt5bdDY/PKnZQMUGEOOhcsnKxlxKUb0F15Om9OuVRhBvw Bgja09+hEuYjheZml5IPgXxMBNBmg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrvdegucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh epuffvfhfhohfkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvghtvghrucfg ihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvdhnughquhgrug hrrghnthdrtghomheqnecuffhomhgrihhnpedvnhguqhhurggurhgrnhhtrdgtohhmnecu kfhppeelfedrvdegvddrvddufedrvdegudenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghuthesvdhnughq uhgrughrrghnthdrtghomh X-ME-Proxy: Received: from april.pezone.net (p5df2d5f1.dip0.t-ipconnect.de [93.242.213.241]) by mail.messagingengine.com (Postfix) with ESMTPA id C7ECB3280063; Sat, 11 Apr 2020 04:06:52 -0400 (EDT) Subject: Re: cleaning perl code To: Noah Misch , Andrew Dunstan References: <20200411043014.GA590991@rfd.leadboat.com> Cc: PostgreSQL-development From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: <840bf563-5399-740a-7f90-bbe0fd9a3e1e@2ndquadrant.com> Date: Sat, 11 Apr 2020 10:06:51 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200411043014.GA590991@rfd.leadboat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 66.111.4.27 (deferred) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-04-11 06:30, Noah Misch wrote: > In summary, among those warnings, I see non-negative value in "Code before > warnings are enabled" only. Now that you put it like this, that was also my impression when I first introduced the level 5 warnings and then decided to stop there. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services