Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVI98-00086l-Cf for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Feb 2023 20:24:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pVI97-0001ve-8K for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Feb 2023 20:24:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVI96-0001vV-UM for pgsql-hackers@lists.postgresql.org; Thu, 23 Feb 2023 20:24:52 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pVI94-0001iX-83 for pgsql-hackers@lists.postgresql.org; Thu, 23 Feb 2023 20:24:51 +0000 Received: by mail-ed1-x536.google.com with SMTP id o12so47163591edb.9 for ; Thu, 23 Feb 2023 12:24:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iA7r/6xtKXt+x8OqjQHw95sy+AI7XubhcrNJzNqI41o=; b=ZszuWbc6lz+zKDZqBk64Ucay0WKYqOmV/ZHlkNt+FTMfjOcnAGRHoNF05FtlRL3mRV GNP8q0o8Ln8o1ElakCkkXnzNhHgIgQ4F1Fc48vooCJjue3ifsn954ui6xhYvrVTzQgTm xqllKgUITVUwOBFAW/2o2w8niK/wMYwSzidFS/8rLCocj8WzHW8whMzpRr16MtKARnuk rcBMOsND53OaQYOh6UDwqKR1fqvQ3uZ8QdnoMUl3DlCn6x0Ryo1pQ+yIw5YV6Z+kcaIQ 2ceaox77iod1Bsw+FN/60mJwOZsRhr1Jx5KejBPQx5KPuNEqA4IQ1xDj5gEbVnIy2e0q PTpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iA7r/6xtKXt+x8OqjQHw95sy+AI7XubhcrNJzNqI41o=; b=g66yPJxaxLdErFgvoyMQpYx1Y62MnqUisD7zScAuU4ZHcn+tSbUvF/0G+Uhou6Mu7x apnKQVvTGZob/kX47I1f2CJow2aWt5v++RwYa+pYAiFIh2iPqqsuwfiypdvM23BWv1Fb QhmbVR4BbsjmQcKYqT9EyYCyjy8HyvA6QsFKF3FK79erqCitK0zIrRnr7br1ViL0/FZz tmljoC0m7EkSx1/xUp+fFGyimxbg3EVdsMT9lZ7zwF5O8ObluOheolfKDRgQKzca6E/Y FE1ATmP9msTHz+y7LHYvl4fYdkkX32ssrOvcvNdANA6QYVP7JCCrJv8OasTNyzEyHnNr Vp1A== X-Gm-Message-State: AO0yUKW93aPq7WeWjQTCs32ippSnOGutE3XYQwqMqpXeyD+Cjl5biFNY A73vSUVSFFjX+T7ZMsxAH5ERPWFn5VZWwJwn4LfHGq/Pj1FjpW4wAKyX+3K9UgFsUZJoj0tyQ6U RsXavKSqUzux0IO3qNFRRK9KWtOUfOnPb5t6yDDFHd+QP47tHMeNVhMMay+GfIewu/FIDcyg2cj Xt9tuY/cfWWcaIGDXxfOo+HvHvv4xJ+hACI2prQxawJDy2x6BRMk6h X-Google-Smtp-Source: AK7set9vEGugpTFORhKb4klghShpqsIJIWP/4YrYOJFgoO800aYmUQzYVWsfiAzRYsgR/d0YhGu9/g== X-Received: by 2002:a17:906:57c6:b0:8b1:fc1a:7d19 with SMTP id u6-20020a17090657c600b008b1fc1a7d19mr22686299ejr.3.1677183887808; Thu, 23 Feb 2023 12:24:47 -0800 (PST) Received: from [10.137.0.17] (static-84-42-175-93.bb.vodafone.cz. [84.42.175.93]) by smtp.gmail.com with ESMTPSA id s4-20020a1709067b8400b008e309da3253sm3107122ejo.202.2023.02.23.12.24.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Feb 2023 12:24:47 -0800 (PST) Message-ID: <8421f53d-c9f7-c02e-3278-9f9522a8e8f3@enterprisedb.com> Date: Thu, 23 Feb 2023 21:24:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Add LZ4 compression in pg_dump Content-Language: en-US From: Tomas Vondra To: gkokolatos@pm.me Cc: "shiy.fnst@fujitsu.com" , Michael Paquier , Justin Pryzby , "pgsql-hackers@lists.postgresql.org" , Rachel Heaton References: <7zu6GYFi72jByVk2SEe_nd8r1DHhwA35vSntAE9sAfiMX9Lfk6bwimkwmu7GDgYaEvL27SE4qF1uK4_LHWQM4H-SXOwkMAI-GV8PKGmED_E=@pm.me> <20230126062846.GO22427@telsasoft.com> <6YZqN2HEE4yJxxxXWiMl4QWwKzLon0SdKETTGVkT9zjWnXMftGZjLKHHjGFuwC_5I6xL2s8nMXdLQGA4vEFveYXSHbfD9K9pDQvEJF2y99o=@pm.me> <535565cd-b69f-c064-a845-15c0fc44db4a@enterprisedb.com> <22cb80ed-ec87-54c7-fd5b-cdcf79766bb1@enterprisedb.com> In-Reply-To: <22cb80ed-ec87-54c7-fd5b-cdcf79766bb1@enterprisedb.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2/23/23 16:26, Tomas Vondra wrote: > Thanks for v30 with the updated commit messages. I've pushed 0001 after > fixing a comment typo and removing (I think) an unnecessary change in an > error message. > > I'll give the buildfarm a bit of time before pushing 0002 and 0003. > I've now pushed 0002 and 0003, after minor tweaks (a couple typos etc.), and marked the CF entry as committed. Thanks for the patch! I wonder how difficult would it be to add the zstd compression, so that we don't have the annoying "unsupported" cases. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company