Feedback-ID: i131946ab:Fastmail
Message-ID: <84550e37-c3e6-94a5-538f-063f6dcacf08@enterprisedb.com>
Date: Wed, 8 Mar 2023 10:26:54 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: Allow tests to pass in OpenSSL FIPS mode
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <dbbd927f-ef1f-c9a1-4ec6-c759778ac852@enterprisedb.com>
 <647f6cc1-473d-f788-ade0-c09201e5ab6a@enterprisedb.com>
 <Y0YV+lQNQFRIdvGJ@paquier.xyz>
 <3c36b798-fbb2-9246-fafd-4e4b2f546de8@enterprisedb.com>
 <6885f06b-79a4-8ded-2261-85a7be68ef4c@enterprisedb.com>
 <Y5K2iK+Q9c5KLnZ2@paquier.xyz>
 <aecaefd1-8a35-0f9e-b258-531baeeca797@enterprisedb.com>
 <3036649.1677971077@sss.pgh.pa.us>
 <a58535cf-0165-636f-1f98-567e52011830@enterprisedb.com>
 <140442.1678261237@sss.pgh.pa.us>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <140442.1678261237@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/84550e37-c3e6-94a5-538f-063f6dcacf08%40enterprisedb.com>
Precedence: bulk

On 08.03.23 08:40, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>> On 05.03.23 00:04, Tom Lane wrote:
>>> I've gone through this and have a modest suggestion: let's invent some
>>> wrapper functions around encode(sha256()) to reduce the cosmetic diffs
>>> and consequent need for closer study of patch changes.  In the attached
>>> I called them "notmd5()", but I'm surely not wedded to that name.
> 
>> Do you mean create this on the fly in the test suite, or make it a new
>> built-in function?
> 
> The former --- please read my version of the patch.

Ok, that makes sense.  We have some other uses of this pattern in other 
test suites that my initial patch didn't cover yet, for example in 
src/test/subscripton, but we don't have expected files there, so the 
argument of reducing the diffs doesn't apply.