Content-Type: multipart/mixed; boundary="------------P4vw12RaMg9y1dWVkCuPVFaL"
Message-ID: <845e3464-cf5e-4e6a-b6ab-5eec6f92f6a6@enterprisedb.com>
Date: Sun, 30 Jun 2024 20:58:02 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pg_combinebackup --clone doesn't work
To: Peter Eisentraut <peter@eisentraut.org>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <48da4a1f-ccd9-4988-9622-24f37b1de2b4@eisentraut.org>
 <c8b9959e-db27-4dc7-be65-7a32570f0a84@enterprisedb.com>
 <9498bcb1-ee7b-484f-b2fb-3d22c48cb4c5@enterprisedb.com>
 <ada6d2f8-f0bd-4fa4-8be2-45211d7adc96@enterprisedb.com>
 <e82966c7-1e2c-4c00-bd50-3010642a1239@eisentraut.org>
Content-Language: en-US
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
In-Reply-To: <e82966c7-1e2c-4c00-bd50-3010642a1239@eisentraut.org>
Archived-At: <https://www.postgresql.org/message-id/845e3464-cf5e-4e6a-b6ab-5eec6f92f6a6%40enterprisedb.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------P4vw12RaMg9y1dWVkCuPVFaL
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi,

I've pushed the first three patches, fixing the headers, adding the
--copy option and PG_TEST_PG_COMBINEBACKUP_MODE variable.

I haven't pushed the CI changes, I'm not sure if there's a clear
consensus on which combination to test. It's something we can tweak
later, I think.

FWIW I've added the patch to the 2024-07 commitfest, but mostly to get
some CI runs (runs on private fork fail with some macos issues unrelated
to the patch).


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--------------P4vw12RaMg9y1dWVkCuPVFaL
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Add-PG_TEST_PG_COMBINEBACKUP_MODE-to-CI-tasks.patch"
Content-Disposition: attachment;
 filename="0001-Add-PG_TEST_PG_COMBINEBACKUP_MODE-to-CI-tasks.patch"
Content-Transfer-Encoding: base64

RnJvbSBjOTJjYzg2MjAyNmQxZDJlNDhkZDk3ZTA1ZjQ5Nzg3M2ZiODUyNTg4IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUb21hcyBWb25kcmEgPHRvbWFzQDJuZHF1YWRyYW50
LmNvbT4KRGF0ZTogU3VuLCAzMCBKdW4gMjAyNCAxOTowMzowMiArMDIwMApTdWJqZWN0OiBb
UEFUQ0ggNC80XSBBZGQgUEdfVEVTVF9QR19DT01CSU5FQkFDS1VQX01PREUgdG8gQ0kgdGFz
a3MKClRoaXMgY2hhbmdlcyBwZ19jb21iaW5lYmFja3VwIG1vZGUgZm9yIHR3byBvZiB0aGUg
Q2lycnVzIENJIHRhc2tzLCB0bwpleGVyY2lzZSB0aGUgYWx0ZXJuYXRpdmUgY29weSBtZXRo
b2RzIGluIHBnX2NvbWJpbmViYWNrdXAgdGVzdHMuIFdlCnRlc3QgLS1jbG9uZSBvbiBtYWNP
UyBhbmQgLS1jb3B5LWZpbGUtcmFuZ2Ugb24gb25lIG9mIHRoZSBMaW51eCB0YXNrcy4KClJl
cG9ydGVkLWJ5OiBQZXRlciBFaXNlbnRyYXV0CkRpc2N1c3Npb246IGh0dHBzOi8vcG9zdGdy
LmVzL20vNDhkYTRhMWYtY2NkOS00OTg4LTk2MjItMjRmMzdiMWRlMmI0JTQwZWlzZW50cmF1
dC5vcmcKLS0tCiAuY2lycnVzLnRhc2tzLnltbCB8IDIgKysKIDEgZmlsZSBjaGFuZ2VkLCAy
IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS8uY2lycnVzLnRhc2tzLnltbCBiLy5jaXJy
dXMudGFza3MueW1sCmluZGV4IDMzNjQ2ZmFlYWRmLi40ZTAyOTEwM2M3ZSAxMDA2NDQKLS0t
IGEvLmNpcnJ1cy50YXNrcy55bWwKKysrIGIvLmNpcnJ1cy50YXNrcy55bWwKQEAgLTMxOCw2
ICszMTgsNyBAQCB0YXNrOgogCiAgICAgICBlbnY6CiAgICAgICAgIFNBTklUSVpFUl9GTEFH
UzogLWZzYW5pdGl6ZT1hZGRyZXNzCisgICAgICAgIFBHX1RFU1RfUEdfQ09NQklORUJBQ0tV
UF9NT0RFOiAtLWNvcHktZmlsZS1yYW5nZQogCiAgICAgICAjIE5vcm1hbGx5LCB0aGUgInJl
bGF0aW9uIHNlZ21lbnQiIGNvZGUgYmFzaWNhbGx5IGhhcyBubyBjb3ZlcmFnZSBpbiBvdXIK
ICAgICAgICMgdGVzdHMsIGJlY2F1c2Ugd2UgKHF1aXRlIHJlYXNvbmFibHkpIGRvbid0IGdl
bmVyYXRlIHRhYmxlcyBsYXJnZQpAQCAtNDMyLDYgKzQzMyw3IEBAIHRhc2s6CiAgICAgQ1hY
RkxBR1M6IC1PZyAtZ2dkYgogCiAgICAgUEdfVEVTVF9QR19VUEdSQURFX01PREU6IC0tY2xv
bmUKKyAgICBQR19URVNUX1BHX0NPTUJJTkVCQUNLVVBfTU9ERTogLS1jbG9uZQogCiAgIDw8
OiAqbWFjb3NfdGFza190ZW1wbGF0ZQogCi0tIAoyLjQ1LjIKCg==

--------------P4vw12RaMg9y1dWVkCuPVFaL--