Message-ID: <8460e17f-7fa1-4df1-b007-e1b234f18064@uni-muenster.de>
Date: Tue, 26 May 2026 12:02:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Avoid leaking system path from pg_available_extensions
To: Chao Li <li.evan.chao@gmail.com>,
 Matheus Alcantara <matheusssilv97@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Andrew Dunstan <andrew@dunslane.net>
References: <357C774A-ECE9-4455-B641-315205D4D9A1@gmail.com>
 <96203151-6929-4d88-85a0-d552ee258a24@gmail.com>
 <cf40d36e-e45a-41c2-aea1-7834bcb62da9@uni-muenster.de>
 <87c8f8ac-614b-4679-afc7-f591b76c8ff7@gmail.com>
 <83AF10FE-7655-43DF-A302-3CAC796B572F@gmail.com>
Content-Language: en-US, de-DE
From: Jim Jones <jim.jones@uni-muenster.de>
In-Reply-To: <83AF10FE-7655-43DF-A302-3CAC796B572F@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/8460e17f-7fa1-4df1-b007-e1b234f18064%40uni-muenster.de>
Precedence: bulk

On 26/05/2026 09:14, Chao Li wrote:
> In theory, I’m not against the idea either. In practice, there are many hard-coded strings in the source tree, and I’m not sure where the right place would be to define this macro.
> 
> Since this string is only used in get_extension_control_directories(), and now it is used three times, I defined it at the beginning of the function and undefined it at the end. Let’s see if there are any objections to that.


I don't feel strongly about it. I only brought it up because hardcoded
strings used in multiple places are usually a recipe for oversights and
painful debugging down the road. That said, as I mentioned, I understand
the argument that this is scoped to a single function, and the fact
they're pretty close to one another also makes it less likely to be
missed, but there is no guarantee it'll stay like that forever.

Thanks for the fix!

Best, Jim