Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eKGYx-0000zr-O0 for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Nov 2017 04:35:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eKGYx-0003VC-69 for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Nov 2017 04:35:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eKGYw-0003V1-Vq for pgsql-hackers@lists.postgresql.org; Thu, 30 Nov 2017 04:35:03 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eKGYt-0005Cd-Pb; Thu, 30 Nov 2017 04:35:02 +0000 Received: from pro.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id vAU4Yuio032394; Wed, 29 Nov 2017 23:34:56 -0500 From: Tom Lane To: Noah Misch cc: Dave Page , Sandeep Thakkar , Ashutosh Sharma , Robert Haas , pgsql-hackers Subject: Re: pl/perl extension fails on Windows In-reply-to: <20171130041441.GA3161526@rfd.leadboat.com> References: <12588.1502375771@sss.pgh.pa.us> <14838.1502379286@sss.pgh.pa.us> <1708!2.1502718166@sss.pgh.pa.us> <10406.1502743029@sss.pgh.pa.us> <1914.1502978317@sss.pgh.pa.us> <4515.1502981857@sss.pgh.pa.us> <17646.1502983856@sss.pgh.pa.us> <19438.1502986558@sss.pgh.pa.us> <20171130041441.GA3161526@rfd.leadboat.com> Comments: In-reply-to Noah Misch message dated "Wed, 29 Nov 2017 20:14:41 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <84898.1512016496.1@sss.pgh.pa.us> Date: Wed, 29 Nov 2017 23:34:56 -0500 Message-ID: <84899.1512016496@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Noah Misch writes: > On Thu, Aug 17, 2017 at 12:15:58PM -0400, Tom Lane wrote: >> ... it's now looking to me like we should do the above with X = 5.13.4. >> That won't be a perfect solution, but it's about the best we can >> readily do. Realistically, nobody out in the wider world is likely >> to care about building current PG releases against such old Perl >> versions on Windows; if we satisfy our older buildfarm critters, >> it's enough for me. > MinGW default behavior matches "cl -D_USE_32BIT_TIME_T", and MSVC >= 2005 > default behavior matches "gcc -D__MINGW_USE_VC2005_COMPAT"[1]. MinGW-built > Perl[2] does not mention _USE_32BIT_TIME_T in $Config{ccflags}, so we > typically must add _USE_32BIT_TIME_T when using MSVC to build 32-bit against > MinGW-built Perl. I'm considering two ways to achieve this: I don't really have an opinion about the relative merits of these changes, but why do anything? The existing solution has the buildfarm happy, and we've not heard any field complaints that I saw. I'm not sure we should spend more time on supporting obsolete toolchain combinations that aren't represented in the buildfarm. regards, tom lane