public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Paul A Jungwirth <[email protected]>
To: jian he <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Aleksander Alekseev <[email protected]>
Cc: PostgreSQL Development <[email protected]>
Subject: Re: [PATCH] Fix null pointer dereference in PG19
Date: Wed, 24 Jun 2026 10:52:24 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+renyW52FJ=+pnh+N_xqjUev_MNUCk_mgD2UC7UT0jyAHCE8Q@mail.gmail.com>
References: <CAJ7c6TME+ix6VRf-2TPnVTsj8qn_hy6sYAOmMhZEivwsu2wS6g@mail.gmail.com>
	<[email protected]>
	<CACJufxFgKVL=NnPocAwhRFqpLHckN3N1Ndf7FjGNTdtsAA26mg@mail.gmail.com>
	<CA+renyW52FJ=+pnh+N_xqjUev_MNUCk_mgD2UC7UT0jyAHCE8Q@mail.gmail.com>

On 15.05.26 23:21, Paul A Jungwirth wrote:
> On Thu, Apr 23, 2026 at 9:45 PM jian he <[email protected]> wrote:
>>
>> On Tue, Apr 21, 2026 at 11:24 PM Tom Lane <[email protected]> wrote:
>>>
>>> * I'd tend to move the anti-FDW check to execution too.
>>> It's not actively wrong, since nowadays we don't permit
>>> relations to change relkind, but it seems out of place.
>>> Also, it seems inadequate to deal with the case of a target
>>> that is a partitioned table having FDW partitions.
>>>
>> Hi.
>>
>> Instead of adding another subnode in CheckValidResultRel,
>> I am passing ModifyTable to it, this will be more future-proof.
> 
> Thank you for working on this! I started a new thread at [1] so that I
> could give it a commitfest entry.
> 
> Your patch looks great to me. I didn't notice that you had posted one,
> so I made my own, but yours is better. Doing the check in
> CheckValidResultRel makes a lot of sense.
> 
> I thought there was one other case we should test for: when a
> partition has a child FDW that gets pruned, we should not raise an
> error. So I swapped in my own tests, which were otherwise similar to
> yours.
> 
> That new thread also includes a patch to move the functionality check
> into plan-time.
> 
> [1] https://www.postgresql.org/message-id/CA%2BrenyUte0_UJsJiDJQi82oaBsMJn%3Dcct0Wn%3DvOqXtuDn%3DYYJA%40...

I don't understand the status of this discussion.  The original bug 
report is related to views and INSTEAD OF triggers.  But the last few 
patches that have been posted here appear to be unrelated to that 
specific issue.

view thread (13+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Fix null pointer dereference in PG19
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox