Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcjs5-0006Y2-Nr for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Mar 2023 09:26:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pcjs4-0005Tj-Cb for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Mar 2023 09:26:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcjs4-0005Sd-1R for pgsql-hackers@lists.postgresql.org; Thu, 16 Mar 2023 09:26:04 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pcjs1-0007vB-N1 for pgsql-hackers@lists.postgresql.org; Thu, 16 Mar 2023 09:26:03 +0000 Received: by mail-wr1-x434.google.com with SMTP id t15so853951wrz.7 for ; Thu, 16 Mar 2023 02:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678958760; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ILJrEU6MJLlRs3KvWCBZFTvCKsgVw06/cPbwFElJ/Ko=; b=FhFNUJvRosa9v1hyv6nufO+Y4qJjb/3jSQ3OCvy3UkgoYvdTEiua6tEUCxU9xNjq/k o7vVNysjCrqnobu69wHE0PI3kig/Dr/yrWWxpGqRa+Dzpd0kHF18t6IU6cTtLTYWiVEW VVxNMrGi265eI8tfuA3EPJRbGUmh/EuDyOlaT/MUhs3Wq/cPSwEaLLw7Rs8CpKzROpoP xaeB2Pxkkx1stakT8XRRAXHfPYO61gTWmjxKDxRAZwv1Nrw08qzvHp14PLYkGay9lwMR ath81r+cwHxFirODf6zE/oKwm6ybS+oJ6X2QIXF8RQOk/+K0vxmp+XTxbjI4FR7WYdN5 ONOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678958760; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ILJrEU6MJLlRs3KvWCBZFTvCKsgVw06/cPbwFElJ/Ko=; b=BpWM+2WyZej0JaDM7CZh4IEssXo9E2D7Xl/bTyN1HrQc6MuwdrzQqCfyNpnb/zkDSe Wx70XiY9rkXqAS9P5ztuMleHfZ40L6MRHBW++dJFsJQZqgIt7kLlvp8yHhWaxF7gF3Tp Y4gupR6gKkxJw/ER5vOcorNTLxErmIuKr3Zeisa31HQ76lBTG99QTpCaZAiofvbSHTAw H2B2Tg10aVz8Mk6kyIjTGQ97lDmH5bpc67UdnhtzsNP2oFSUmYUE9LKG23OKmcXSN0+O KlKCw3kipBGU0G6X/t5st6Ir8/h0aFdzELka9thpFVK68DWXW1GCfMFA07RXy5qddXV4 UBhA== X-Gm-Message-State: AO0yUKWIYNqDx5tVCy/iaoyVMwXSxJ0XZ7o3m3GXR4PclaznpvMBintd NXKaUBT5BZ7M8SqTZYBkz5Y= X-Google-Smtp-Source: AK7set/CEm6a1pJh2B5oWghuMrIASi3Wg4gQo9uZJqj2sWv6EjwAdhh/CHpy9pF72EurA8HNZbxGQw== X-Received: by 2002:a5d:55d0:0:b0:2c7:6a6c:c71e with SMTP id i16-20020a5d55d0000000b002c76a6cc71emr3513786wrw.70.1678958760243; Thu, 16 Mar 2023 02:26:00 -0700 (PDT) Received: from [192.168.22.74] ([54.239.6.186]) by smtp.gmail.com with ESMTPSA id z17-20020a5d4d11000000b002c5a1bd527dsm6729067wrt.96.2023.03.16.02.25.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Mar 2023 02:25:59 -0700 (PDT) Message-ID: <84fc9810-9688-8791-25f6-e80ef1fb9b5b@gmail.com> Date: Thu, 16 Mar 2023 10:25:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Get rid of PgStat_BackendFunctionEntry Content-Language: en-US To: Michael Paquier , Nathan Bossart Cc: PostgreSQL Hackers References: <11d531fe-52fc-c6ea-7e8e-62f1b6ec626e@gmail.com> <20230308213838.GA3599633@nathanxps13> From: "Drouvot, Bertrand" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 3/16/23 6:25 AM, Michael Paquier wrote: > On Wed, Mar 08, 2023 at 01:38:38PM -0800, Nathan Bossart wrote: >> Looks reasonable to me. > > I have been catching up with this thread and the other thread, and > indeed it looks like this is going to help in refactoring > pgstatfuncs.c to have more macros for all these mostly-duplicated > functions. So, I have applied this bit. Thanks! Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com