Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6cmC-0007f8-K4 for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Jul 2021 17:46:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m6clg-0002Br-24 for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Jul 2021 17:45:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6clf-0002BI-QS for pgsql-hackers@lists.postgresql.org; Thu, 22 Jul 2021 17:45:55 +0000 Received: from mxout4.routing.net ([2a03:2900:1:a::9]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6cld-0001e6-Jg for pgsql-hackers@lists.postgresql.org; Thu, 22 Jul 2021 17:45:55 +0000 Received: from mxbox2.masterlogin.de (unknown [192.168.10.89]) by mxout4.routing.net (Postfix) with ESMTP id DE08C1006A2; Thu, 22 Jul 2021 17:45:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailerdienst.de; s=20200217; t=1626975950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m3z0hPrrlnbOi1/5Hqg1jOQ6nOxQ02UlChY99U0FzJQ=; b=CGosfURg2u5OLUYa9hArB5dpnmxGYH/SAhe6dM+3xI4WTje/MFSyv0coqORPs02X9AF+HA I0JmmiQMatvcasMVEYfvVmomHDyFDdaPSBYhMj09+4+ze0ijCyE0dkKkKzvFKHzKBHiy/B pFBT+xCpZ9aF+aN9I6X68MNaSRNQxpA= Received: from remote.index.de (p578a9a34.dip0.t-ipconnect.de [87.138.154.52]) by mxbox2.masterlogin.de (Postfix) with ESMTPSA id 5A98C100532; Thu, 22 Jul 2021 17:45:50 +0000 (UTC) Received: from acedia.index-gruppe.local (192.168.3.121) by acedia.index-gruppe.local (192.168.3.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 22 Jul 2021 19:45:49 +0200 Received: from acedia.index-gruppe.local ([fe80::d96c:8551:78c8:d947]) by acedia.index-gruppe.local ([fe80::d96c:8551:78c8:d947%13]) with mapi id 15.01.2176.014; Thu, 22 Jul 2021 19:45:49 +0200 From: Arne Roland To: Alvaro Herrera CC: vignesh C , Zhihong Yu , Pg Hackers Subject: Re: Rename of triggers for partitioned tables Thread-Topic: Rename of triggers for partitioned tables Thread-Index: AQHWxEk1+rora/wutkWbcRQhC03q0KnbGQ2sgAAECBOATmSTgIBhAeKAgBDG6bOAACCNT4AAKOcAgAAj1kP///tHgIAEsSJngAHhzjCAhX9QJP//43kAgAAjD3T///1iAABXUKhwA1bKhQAABHSL9QDdrxEAAARjdxL///exAIABN1SAgAG0zACAASTOjIAACgeAgAAiw8X///GFAIAAI3Bn Date: Thu, 22 Jul 2021 17:45:49 +0000 Message-ID: <85343944ff5f43d8b30fdd258a97d85b@index.de> References: <29dca60bc79e4c2ab26fa328a94b1289@index.de>,<202107221733.lnopatzhx3zt@alvherre.pgsql> In-Reply-To: <202107221733.lnopatzhx3zt@alvherre.pgsql> Accept-Language: en-US, de-DE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.1.33] Content-Type: multipart/alternative; boundary="_000_85343944ff5f43d8b30fdd258a97d85bindexde_" MIME-Version: 1.0 X-Mail-ID: 1fa865a0-b0f1-42b1-a1f2-3828628136f1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --_000_85343944ff5f43d8b30fdd258a97d85bindexde_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable From: Alvaro Herrera Sent: Thursday, July 22, 2021 19:33 To: Arne Roland Subject: Re: Rename of triggers for partitioned tables On 2021-Jul-22, Arne Roland wrote: > Since it is sort of the same problem, I think it might be worthwhile > to address it as well within this patch. Adding two to four ereports > doesn't sound like scope creeping to me, even though it touches > completely different code. I'll look into that as well. I don't understand what you mean. But here's an updated patch, with the following changes alter table middle disable trigger b; creates the same kind of inconsistency alter trigger b on middle rename to something; does. With other words: enableing/disabling non-topmost triggers should be forbid= den as well. Regards Arne --_000_85343944ff5f43d8b30fdd258a97d85bindexde_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
Sent: Thursday, July 22, = 2021 19:33
To: Arne Roland
Subject: Re: Rename of triggers for partitioned tables
 
On 2021-Jul-22, Arne Roland wrote:

> Since it is sort of the same problem, I think it might be worthwhile > to address it as well within this patch. Adding two to four ereports > doesn't sound like scope creeping to me, even though it touches
> completely different code. I'll look into that as well.

I don't understand what you mean.  But here's an updated patch, with t= he
following changes

alter table middle disable trigger b;
creates the same kind of inconsistency
<= span>alter tr= igger b on middle rename to something;
does.
With other wor= ds: enableing/disabling non-topmost tri= ggers should be forbidden as well.

Regards
Arne
--_000_85343944ff5f43d8b30fdd258a97d85bindexde_--