Received: from localhost (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id 94C60633A72 for ; Fri, 16 Oct 2009 14:33:27 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 64495-07 for ; Fri, 16 Oct 2009 17:33:15 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by mail.postgresql.org (Postfix) with ESMTP id 1C2976338B3 for ; Fri, 16 Oct 2009 14:33:16 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id n9GHX53G008580; Fri, 16 Oct 2009 13:33:05 -0400 (EDT) To: Greg Stark cc: KaiGai Kohei , Stephen Frost , robertmhaas@gmail.com, pgsql-hackers@postgresql.org, kaigai@kaigai.gr.jp Subject: Re: Reworks for Access Control facilities (r2363) In-reply-to: <407d949e0910160945x6bb99198xb3c23b9554669361@mail.gmail.com> References: <4AC5A14F.6050306@ak.jp.nec.com> <20091012024604.GW17756@tamriel.snowman.net> <4AD54082.9050001@ak.jp.nec.com> <10495.1255627322@sss.pgh.pa.us> <4AD7CCDD.1070402@ak.jp.nec.com> <407d949e0910160945x6bb99198xb3c23b9554669361@mail.gmail.com> Comments: In-reply-to Greg Stark message dated "Fri, 16 Oct 2009 17:45:54 +0100" Date: Fri, 16 Oct 2009 13:33:05 -0400 Message-ID: <8579.1255714385@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.576 tagged_above=-10 required=5 tests=AWL=0.023, BAYES_00=-2.599 X-Spam-Level: X-Archive-Number: 200910/962 X-Sequence-Number: 147774 Greg Stark writes: > The first step is to add hooks which don't change the security model > at all, just allow people to control the existing checks from their SE > configuration. This is in fact what the presented patch is meant to do. The issue is about whether the hook placement is sane/useful/extensible. The main problem I've got with the design is that it doesn't appear to work for privilege checks made by add-on modules. regards, tom lane