From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dave Cramer <davecramer@gmail.com>
cc: Robert Haas <robertmhaas@gmail.com>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Peter Smith <smithpb2250@gmail.com>, Tatsuo Ishii <ishii@sraoss.co.jp>,
        pgsql-hackers@lists.postgresql.org, nathandbossart@gmail.com
Subject: Re: Using defines for protocol characters
In-reply-to: <CADK3HHJBmf5YgbW4bnSA5kBawgrZxyxDa2xQJDFHoGdC6hhEgg@mail.gmail.com>
References: <CAHut+PuE-3tc_6m06bwnjftk2KBM728ZSDhuL1_=vRCfEGMZ1A@mail.gmail.com> <20230807091044.jjgsl2rgheazaung@alvherre.pgsql> <CADK3HH+aXM82oY-tUzidBS1bfqoUFubVxygmFaBFZFV=3iHYdw@mail.gmail.com> <CA+TgmoZ=XfKEqiq80SbN0R_XpLnnkgjGuO5WBTL0nYTseKD4TQ@mail.gmail.com> <838284.1691432698@sss.pgh.pa.us> <CA+TgmoYhA4Df2euFVK24NU9qkcHZBfbJTsr9M=4UWsr+sayD8Q@mail.gmail.com> <CADK3HHJBmf5YgbW4bnSA5kBawgrZxyxDa2xQJDFHoGdC6hhEgg@mail.gmail.com>
Comments: In-reply-to Dave Cramer <davecramer@gmail.com>
	message dated "Mon, 07 Aug 2023 14:00:25 -0600"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <859244.1691438528.1@sss.pgh.pa.us>
Date: Mon, 07 Aug 2023 16:02:08 -0400
Message-ID: <859245.1691438528@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/859245.1691438528%40sss.pgh.pa.us>
Precedence: bulk

Dave Cramer <davecramer@gmail.com> writes:
> On Mon, 7 Aug 2023 at 12:59, Robert Haas <robertmhaas@gmail.com> wrote:
>> PqMsgEmptyQueryResponse or something like that seems better, if we
>> want to keep the current capitalization. I'm not a huge fan of the way
>> we vary our capitalization conventions so much all over the code base,
>> but I think we would at least do well to keep it consistent from one
>> end of a certain identifier to the other.

> I don't have a strong preference, but before I make the changes I'd like to
> get consensus.
> Can we vote or whatever it takes to decide on a naming pattern that is
> acceptable ?

I'm good with Robert's proposal above.

			regards, tom lane