public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Yugo NAGATA <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: [email protected]
Subject: Re: Remove unnecessary code from psql's watch command
Date: Fri, 08 Mar 2024 12:09:12 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Yugo NAGATA <[email protected]> writes:
> On Wed, 06 Mar 2024 13:03:39 -0500
> Tom Lane <[email protected]> wrote:
>> I don't have Windows here to test on, but does the WIN32 code
>> path work at all?

> The outer loop is eventually exited even because PSQLexecWatch returns 0
> when cancel_pressed = 0. However, it happens after executing an extra
> query in this function not just after exit of the inner loop. Therefore,
> it would be better to adding set and check of "done" in WIN32, too.

Ah, I see now.  Agreed, that could stand improvement.

> I've attached the updated patch (v2_remove_unnecessary_code_in_psql_watch.patch).

Pushed with minor tidying.

			regards, tom lane

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Remove unnecessary code from psql's watch command
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox