Message-ID: <85eb62cd-76f3-d01f-79ef-144173c16edc@enterprisedb.com>
Date: Wed, 10 Nov 2021 11:56:10 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.0
Subject: Re: Time to drop plpython2?
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
References: <20211031184548.g4sxfe47n2kyi55r@alap3.anarazel.de>
 <08a65981-7fec-1b9b-4061-6e3086c05914@enterprisedb.com>
 <3fc1211d-960b-4b2f-3e96-a6099db847fc@enterprisedb.com>
 <20211104195443.dystyijvufveikcp@alap3.anarazel.de>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20211104195443.dystyijvufveikcp@alap3.anarazel.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/85eb62cd-76f3-d01f-79ef-144173c16edc%40enterprisedb.com>
Precedence: bulk

On 04.11.21 20:54, Andres Freund wrote:
>> Finally, morally related, there is some Python 2/3 compat code in
>> contrib/unaccent/generate_unaccent_rules.py that could be removed. Also,
>> arguably, change the shebang line in that script.
> 
> Hm. So far the python used for plpython and python for code generation etc is
> independent. I don't know if plpython actually can be cross-compiled, but if
> so, they'd have to be independent.  Otherwise I'd say we should just invoke
> contrib/unaccent/generate_unaccent_rules.py with a python chosen by
> configure/meson, rather than relying on a shebang that can't be adjusted
> without modifying source code.

We don't rely on the shebang for running this (see Makefile).  I just 
see some trend of people changing shebang lines as a sort of signal, 
"this script has abandoned Python 2".  It's not very important.

> Another thing I wondered about is what we want to do with the extension
> names. Do we want to leave it named plpython3u? Do we want to have a plpython
> that depends on plpython3u?

I would tend to mirror what the Python community does with 
/usr/bin/python.  Right now, most people are removing /usr/bin/python 
and just provide /usr/bin/python3.  This would be analogous to what your 
patch does.  Some time in the future, they may add /usr/bin/python back, 
and then we could do the same, meaning add a plpythonu that depends on 
plpython3u.