public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: [email protected]
Subject: Re: pg_sequence_last_value() for unlogged sequences on standbys
Date: Tue, 07 May 2024 15:02:01 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <20240507184051.GA2600328@nathanxps13>
References: <20240501005730.GA594666@nathanxps13>
	<[email protected]>
	<20240501011317.GC594666@nathanxps13>
	<20240501020531.GA721953@nathanxps13>
	<[email protected]>
	<20240503204908.GA1737291@nathanxps13>
	<[email protected]>
	<[email protected]>
	<20240507171033.GA2524814@nathanxps13>
	<[email protected]>
	<20240507184051.GA2600328@nathanxps13>

Nathan Bossart <[email protected]> writes:
> On Tue, May 07, 2024 at 01:44:16PM -0400, Tom Lane wrote:
>> +1 to include that, as it offers a defense if someone invokes this
>> function directly.  In HEAD we could then rip out the test in the
>> view.

> I apologize for belaboring this point, but I don't see how we would be
> comfortable removing that check unless we are okay with other sessions'
> temporary sequences appearing in the view, albeit with a NULL last_value.

Oh!  You're right, I'm wrong.  I was looking at the CASE filter, which
we could get rid of -- but the "WHERE NOT pg_is_other_temp_schema(N.oid)"
part has to stay.

			regards, tom lane

view thread (19+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pg_sequence_last_value() for unlogged sequences on standbys
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox