From: Tom Lane <tgl@sss.pgh.pa.us>
To: Denis Garsh <d.garsh@arenadata.io>
cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: Add system column support to the USING clause
In-reply-to: <333431726204057@mail.yandex.ru>
References: <333431726204057@mail.yandex.ru>
Comments: In-reply-to Denis Garsh <d.garsh@arenadata.io>
	message dated "Fri, 13 Sep 2024 11:03:42 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <86135.1726239379.1@sss.pgh.pa.us>
Date: Fri, 13 Sep 2024 10:56:19 -0400
Message-ID: <86136.1726239379@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/86136.1726239379%40sss.pgh.pa.us>
Precedence: bulk

Denis Garsh <d.garsh@arenadata.io> writes:
> The patch adds support for system columns in JOIN USING clause.

I think this is an actively bad idea, and it was likely intentional
that it's not supported today.  A few reasons why:

* There are, fundamentally, no use-cases for joining on system
columns.  The only one that is stable enough to even consider
using for the purpose is tableoid, and I'm not detecting a reason
why that'd be useful.  If there are any edge cases where people
would actually wish to do that, it can be done easily enough with
a standard JOIN ON clause.

* Non-heap table AMs may not provide the same system columns that
heap does, further reducing the scope for plausible use-cases.
(Yeah, I know we don't support that too well today.)

* This breaks ruleutils.c's mechanism for dealing with name
conflicts across multiple USING clauses.  That relies on being
able to assign aliases to the USING inputs at the table level
(that is, "FROM realtable AS aliastable(aliascolumn,...)").
There's no way to alias a system column in the FROM syntax.

			regards, tom lane