Subject: Re: [PG13] Planning (time + buffers) data structure in explain plan
 (format text)
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pierre Giraud <pierre.giraud@dalibo.com>,
 pgsql-hackers@lists.postgresql.org, depesz@depesz.com, depesz@gmail.com
References: <07b226e6-fa49-687f-b110-b7c37572f69e@dalibo.com>
 <20200819032706.GQ17022@telsasoft.com> <20200819072133.jnmtux7qbyxywh6r@nol>
 <CAApHDvrDpJNMpXMS3SNkeUitXrZAFRZ3MrzQG6ieC7vQte6aWA@mail.gmail.com>
 <20200819090429.s7hoyyw4a6jumgkc@nol>
 <CAApHDvr0hMeEDB6HE=GE6vc2kJjCoiWe7z+CVyD9CoAUB+Cpjw@mail.gmail.com>
 <e7361ab4-5b6b-9667-e25b-04ae0b070ded@oss.nttdata.com>
 <CAApHDvqWSk5tVqY9=SwsOF03xOJyrvwoavdDoNjV+2Wk10vsuQ@mail.gmail.com>
 <5605ac79-90c0-6a5f-256d-5cabf52a3fe8@oss.nttdata.com>
 <CAApHDvoU32j3FpVFzdf7qrMmhPwd8VTy1g5nAwkh083bWELQxA@mail.gmail.com>
 <CAOBaU_bOrsngOyYhHUZ0tVGzE9FJsB4nviBZQ7zxjehsYmsWPQ@mail.gmail.com>
 <0d074a53-fd91-b1dd-a529-173d07627465@oss.nttdata.com>
 <4e932e5e-8d86-4dcd-632e-f7c6e2c35a83@dalibo.com>
 <b10c76ce-ae6d-85ff-b185-10b00567d4ed@oss.nttdata.com>
 <1803897.1598021621@sss.pgh.pa.us>
 <a2bd31a4-6c9f-61a8-e75a-e03a164dfc08@oss.nttdata.com>
Message-ID: <861aa8a0-82a0-3233-60fa-2c2c980e359e@oss.nttdata.com>
Date: Sat, 22 Aug 2020 01:54:20 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <a2bd31a4-6c9f-61a8-e75a-e03a164dfc08@oss.nttdata.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2020/08/22 1:04, Fujii Masao wrote:
> 
> 
> On 2020/08/21 23:53, Tom Lane wrote:
>> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>>> Pushed. Thanks!
>>
>> Buildfarm shows this patch has got problems under
>> -DRELCACHE_FORCE_RELEASE and/or -DCATCACHE_FORCE_RELEASE:
>>
>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2020-08-21%2011%3A54%3A12
> 
> Thanks for the report!
> 
> This happens because, in text format, whether "Planning:" line is output
> varies depending on the system state. So explain_filter() should ignore
> "Planning:" line. Patch attached. I'm now checking whether the patched
> version works fine.

I pushed the patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION