Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uMVNK-00DfaX-Sn for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Jun 2025 17:24:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uMVNI-002XTi-PB for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Jun 2025 17:24:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uMVNI-002XTa-G9 for pgsql-hackers@lists.postgresql.org; Tue, 03 Jun 2025 17:24:33 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uMVNH-0002Mj-1N for pgsql-hackers@lists.postgresql.org; Tue, 03 Jun 2025 17:24:32 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 553HOGZQ862471; Tue, 3 Jun 2025 13:24:16 -0400 From: Tom Lane To: Robert Haas cc: Daria Shanina , Melanie Plageman , Heikki Linnakangas , pgsql-hackers@lists.postgresql.org Subject: Re: autoprewarm_dump_now In-reply-to: References: <71abd264-1911-46a0-a25b-079a7cfa577a@iki.fi> <1876464.1748524908@sss.pgh.pa.us> Comments: In-reply-to Robert Haas message dated "Tue, 03 Jun 2025 13:17:43 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <862469.1748971456.1@sss.pgh.pa.us> Date: Tue, 03 Jun 2025 13:24:16 -0400 Message-ID: <862470.1748971456@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Robert Haas writes: > I think the proposed patch should be committed and back-patched, after > fixing it so that it's pgindent-clean and adding a comment. Does > anyone have strong objection to that? Not here. I do wonder if we can't find a more memory-efficient way, but I concur that any such change would likely not be back-patch material. regards, tom lane