From: Tom Lane <tgl@sss.pgh.pa.us>
To: Hubert Zhang <zhubert@vmware.com>
cc: "tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Multiple hosts in connection string failed to failover in non-hot
 standby mode
In-reply-to: 
 <SN6PR05MB4909B53E8D3D8523D72328EAC9AB0@SN6PR05MB4909.namprd05.prod.outlook.com>
References: 
 <BN6PR05MB3492948E4FD76C156E747E8BC9160@BN6PR05MB3492.namprd05.prod.outlook.com>,<TYAPR01MB299012CAC510D2644AEC2246FE160@TYAPR01MB2990.jpnprd01.prod.outlook.com>
 <BN6PR05MB3492DFB2FF32B771172CC2F2C9170@BN6PR05MB3492.namprd05.prod.outlook.com>
 <229507.1610056206@sss.pgh.pa.us>
 <770711.1610318330@sss.pgh.pa.us>,<810463.1610333794@sss.pgh.pa.us>
 <SN6PR05MB4909B53E8D3D8523D72328EAC9AB0@SN6PR05MB4909.namprd05.prod.outlook.com>
Comments: In-reply-to Hubert Zhang <zhubert@vmware.com>
	message dated "Mon, 11 Jan 2021 14:31:40 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <864103.1610378152.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 11 Jan 2021 10:15:52 -0500
Message-ID: <864104.1610378152@sss.pgh.pa.us>
Precedence: bulk

Hubert Zhang <zhubert@vmware.com> writes:
> As for patch 0004, find ':' after "could not connect to" may failed when=
 error message like:
> "could not connect to host "localhost" (::1), port 12345: Connection ref=
used", where p2 will point to "::1" instead of ": Connection refused". But=
 since it's only used for test case, we don't need to filter the error mes=
sage precisely.

Excellent point, and I think that could happen on a Windows installation.
We can make it look for ": " instead of just ':', and that'll reduce the
odds of trouble.

			regards, tom lane