Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ugjAu-006kxE-NZ
	for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Jul 2025 12:11:21 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ugjAt-000aek-Kj
	for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Jul 2025 12:11:19 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ugjAt-000aec-Aj
	for pgsql-hackers@lists.postgresql.org; Tue, 29 Jul 2025 12:11:19 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ugjAq-001TkW-0U
	for pgsql-hackers@lists.postgresql.org;
	Tue, 29 Jul 2025 12:11:19 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 56TCBBIp865405;
	Tue, 29 Jul 2025 08:11:11 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jim Jones <jim.jones@uni-muenster.de>
cc: Erik Wienhold <ewie@ewie.name>, Michael Paquier <michael@paquier.xyz>,
        Robert Treat <rob@xzilla.net>,
        Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Regression with large XML data input
In-reply-to: <93116cb2-e3e2-40bf-be9b-77a2f68fd10a@uni-muenster.de>
References: <1691195.1753383449@sss.pgh.pa.us>
 <1721385.1753385039@sss.pgh.pa.us>
 <7a9a9804-01d8-4489-a831-1a222bae6705@uni-muenster.de>
 <aILK3nMlw6pp-XhA@paquier.xyz>
 <CABV9wwOY3pH+pA0R1hSq5g_DXqeDaGWRuoBEE4QwWLfTiw+nKw@mail.gmail.com>
 <1944118.1753467686@sss.pgh.pa.us> <aIbb3TOq3XP923e5@paquier.xyz>
 <314265.1753669007@sss.pgh.pa.us> <aIbk39Uit4oAigig@paquier.xyz>
 <cc0bd778-9730-4ef9-98b3-a965f8895331@uni-muenster.de>
 <457dd309-158f-43cd-81d4-df7284f30d4f@ewie.name>
 <483421.1753727323@sss.pgh.pa.us> <628881.1753733767@sss.pgh.pa.us>
 <93116cb2-e3e2-40bf-be9b-77a2f68fd10a@uni-muenster.de>
Comments: In-reply-to Jim Jones <jim.jones@uni-muenster.de>
	message dated "Tue, 29 Jul 2025 12:15:28 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <865403.1753791071.1@sss.pgh.pa.us>
Date: Tue, 29 Jul 2025 08:11:11 -0400
Message-ID: <865404.1753791071@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/865404.1753791071%40sss.pgh.pa.us>
Precedence: bulk

Jim Jones <jim.jones@uni-muenster.de> writes:
> Out of curiosity, what's the reasoning behind keeping node_list instead
> of directly using parsed_nodes in the xmlParseBalancedChunkMemory call?

In the original coding, there was a hazard of the node list getting
leaked if the caller passed parsed_nodes == NULL.  Or at least I
thought there was.  It may be that all releases of libxml2 are smart
enough to free the node list if there's no way to pass it back,
but I guess we had reason not to trust it.  Possibly there's something
about that in the discussion that led up to 6082b3d5d, though I see
I neglected to mention it in the commit message.

			regards, tom lane