Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbhrC-00053S-Nm for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Apr 2022 12:00:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nbhqD-0002kM-GL for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Apr 2022 11:59:21 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbhqD-0002hu-4p for pgsql-hackers@lists.postgresql.org; Tue, 05 Apr 2022 11:59:21 +0000 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nbhqA-00083S-Bg for pgsql-hackers@lists.postgresql.org; Tue, 05 Apr 2022 11:59:20 +0000 Received: by mail-ej1-x629.google.com with SMTP id p15so26156526ejc.7 for ; Tue, 05 Apr 2022 04:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec-at.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:comments:mime-version :content-id:content-transfer-encoding:date:message-id; bh=PBVbvwZVZwoGnrI5rwtr1nW14vdqh+QU9dEoFdLMoqw=; b=KnB/Fck6JVoYba39v8A1Qr58d3KfCD42V24nNAJEfq3UTNUx1RDHTzRG5R6LaqFY26 ZirvGVny2XagGNwf1/FHdhglj7pkp3UwRsn8DQe8oZxBXb36cin/HAefRJ/ztDEmAaUz jcPL2FltMHK0Di7JTCXhzqD1YY6327zVOFFfxG4K8MPTF2d/MbWZpiNPUwkRi6Gumawt h+jg2zo+xG25gw0z+F/9n0T1ZYZt0OqN2FmI1FWMqmTw0XAM+RR0BZYJK1f3D0GQhTMV cvRwLAOS1lLsEIt54B5cMSqtjGOybh0aR1UrKtrWfJHb9WG/wfl9EF8pzYDLLOxAKX7H OUyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :comments:mime-version:content-id:content-transfer-encoding:date :message-id; bh=PBVbvwZVZwoGnrI5rwtr1nW14vdqh+QU9dEoFdLMoqw=; b=emc8RDyQPXTK16R38QzryOrKB9b7ocLGFf0Wl19IcKA+j+8p0WrP5NUf9rWDohWTfg kEtNqpVrDV+Ue457I9zFwiU50p3iH54CbZfTOYd5MWi433rHGaRFKefXcHFDYXctd6uK ytaSJH2W5HWWHL0dOxip2CEi8XNYFt31hOfWAdXpAJi/BY9xPMDc5F76SI8tLzh5bsXz S8LPTA9FE20YjAsCSsNbbR2ROBRsZ3Zz7F5AcvmtbOsMpVQVyRrZdlEPvy5Q4vrx2wgv kP+xEDCeyZMQjV02dS38Dv/9TQuRkjRsLmUxXgO+Cpb7R3o2dq71kAl3WzodxdcXXGaC rO3Q== X-Gm-Message-State: AOAM533xUuc0qtdqduX5Qsq1x1/B/HlnXL+eIBsEsB6fNrowdMGJ3yrF XkBkLcLzUsOSTdA8JRbynIVSJy8jbMv4zw== X-Google-Smtp-Source: ABdhPJxXGTF4EEUCNER/opvhhggf9uRSwAMNtGZKVEMyDcIuX8Gro5XM4igcm0Nflc4bNoaIjwrT4A== X-Received: by 2002:a17:906:7955:b0:6e8:a9b:8c7b with SMTP id l21-20020a170906795500b006e80a9b8c7bmr3170835ejo.691.1649159955554; Tue, 05 Apr 2022 04:59:15 -0700 (PDT) Received: from antos (85-207-121-76.static.bluetone.cz. [85.207.121.76]) by smtp.gmail.com with ESMTPSA id p14-20020a05640210ce00b00413211746d4sm6568394edu.51.2022.04.05.04.59.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 04:59:14 -0700 (PDT) From: Antonin Houska To: Amit Kapila cc: PostgreSQL Hackers Subject: Re: Logical replication row filtering and TOAST In-reply-to: References: <84638.1649152255@antos> <85262.1649154136@antos> Comments: In-reply-to Amit Kapila message dated "Tue, 05 Apr 2022 16:02:05 +0530." X-Mailer: MH-E 8.6+git; nmh 1.7+dev; GNU Emacs 27.2.50 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <86624.1649159970.1@antos> Content-Transfer-Encoding: quoted-printable Date: Tue, 05 Apr 2022 13:59:30 +0200 Message-ID: <86626.1649159970@antos> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Amit Kapila wrote: > > Antonin Houska wrote: > > > > Nevertheless, a comment in pgoutput_row_filter(), saying that TOASTed = values > > are not expected if old_slot is NULL, might be useful. > > > = > How about something like the attached? Yes, that'd be sufficient. Thanks. -- = Antonin Houska Web: https://www.cybertec-postgresql.com