From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Justin Pryzby <pryzby@telsasoft.com>, Hubert Zhang <zhubert@vmware.com>,
        tsunakawa.takay@fujitsu.com, pgsql-hackers@postgresql.org,
        Andreas Seltenreich <seltenreich@gmx.de>,
        Bruce Momjian <bruce@momjian.us>
Subject: Re: Multiple hosts in connection string failed to failover in non-hot
 standby mode
In-reply-to: <YL3AHgBeUoFPM6lT@paquier.xyz>
References: <20210531012500.GP2082@telsasoft.com>
 <YLRDV0MqQnGRIo4c@paquier.xyz> <YLRZH6CWs9N6Pusy@paquier.xyz>
 <2522602.1622433912@sss.pgh.pa.us> <YLSCrAPVfxX3X8ap@paquier.xyz>
 <2566986.1622468180@sss.pgh.pa.us> <YLWFzzrUIy9Q8h1d@paquier.xyz>
 <2732890.1622509658@sss.pgh.pa.us> <YLXjFOV3teAPirmS@paquier.xyz>
 <744012.1623014869@sss.pgh.pa.us> <YL3AHgBeUoFPM6lT@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Mon, 07 Jun 2021 15:43:42 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <869605.1623076683.1@sss.pgh.pa.us>
Date: Mon, 07 Jun 2021 10:38:03 -0400
Message-ID: <869606.1623076683@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/869606.1623076683%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Sun, Jun 06, 2021 at 05:27:49PM -0400, Tom Lane wrote:
>> So I took
>> a look at disabling GSSENC in these test cases to try to silence
>> hamerkop's test failure that way.  Here's a proposed patch.
>> It relies on setenv() being available, but I think that's fine
>> because we link the ECPG test programs with libpgport.

> No, that's not it.  The compilation of the tests happens when
> triggering the tests as of ecpgcheck() in vcregress.pl so I think that
> this is going to fail.  This requires at least the addition of a
> reference to libpgport in ecpg_regression.proj, perhaps more.

Hmm.  We do include "-lpgcommon -lpgport" when building the ecpg test
programs on Unix, so I'd assumed that the MSVC scripts did the same.
Is there a good reason not to make them do so?

			regards, tom lane