Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: DOC: fixes multiple errors in alter table doc
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CAHGQGwFk=rrhrwGwPtQxBesbT4DzSZ86Q3ftcwCu3AR5bOiXLw@mail.gmail.com>
Date: Mon, 2 Mar 2026 17:22:29 +0800
Cc: Robert Treat <rob@xzilla.net>,
 Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <86974902-199B-413E-B4DA-9A484AB3A119@gmail.com>
References: 
 <CAEoWx2n6ShLMOnjOtf63TjjgGbgiTVT5OMsSOFmbjGb6Xue1Bw@mail.gmail.com>
 <CABV9wwMPmo-dg=oV+NaJGa_==uo5+TTvk58aNtjVQZBtMcRVBw@mail.gmail.com>
 <CAEoWx2kkh5kCZwYOYaOVShjh3un2mJTGrcFZyhJXd320PHYfJw@mail.gmail.com>
 <CAJSLCQ10_gia2-GzQndwoM-n-v2DWz4LnAY5jyO2ZmNiE+56tA@mail.gmail.com>
 <E9FEE306-E00D-4ECA-97B0-219BE7AB5169@gmail.com>
 <7D4CB5FF-6599-4157-A9E3-7B5E2CB96CEE@gmail.com>
 <CAEoWx2mOW=JMjSNrNsc3b-+8w0wbT2f6FSsyudD_Q-0pe_fkfw@mail.gmail.com>
 <CAHGQGwFk=rrhrwGwPtQxBesbT4DzSZ86Q3ftcwCu3AR5bOiXLw@mail.gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/86974902-199B-413E-B4DA-9A484AB3A119%40gmail.com>
Precedence: bulk


> On Mar 2, 2026, at 17:04, Fujii Masao <masao.fujii@gmail.com> wrote:
>=20
> On Thu, Jan 22, 2026 at 6:38=E2=80=AFPM Chao Li =
<li.evan.chao@gmail.com> wrote:
>> PFA v3: Rebased, and added reviewer and discussion information.
>=20
> LGTM.
>=20
> Should we apply the same change to the ALTER FOREIGN TABLE docs as =
well?

Sure, I can make the change.

>=20
> While reviewing that section, I noticed that ADD COLUMN IF NOT EXISTS =
appears
> to work for ALTER FOREIGN TABLE, but it isn't documented. I'm not sure =
why
> it was left out, but perhaps we should document it and add a =
regression test in
> a separate patch?
>=20

I will verify that, then update the doc and regression test accordingly.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/