Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXicM-0006qw-Iq for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Mar 2023 13:05:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pXicL-0007IE-CJ for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Mar 2023 13:05:05 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXicK-0007I3-Uf for pgsql-hackers@lists.postgresql.org; Thu, 02 Mar 2023 13:05:05 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pXicI-00019d-Ey for pgsql-hackers@lists.postgresql.org; Thu, 02 Mar 2023 13:05:03 +0000 Received: by mail-wr1-x433.google.com with SMTP id q16so16477609wrw.2 for ; Thu, 02 Mar 2023 05:05:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=mTXyYAomhVjJ7+iNieUmgqIEYlpcaXWf0G4caK1J72A=; b=cuEt4Nf32Wmj202kXPNzgjiVwbdcHNO1+7z/Ph2cq6zV2/8RBMjbYRMKU93KUKWECn RFSCmc5FYt/tYdrOLJMIOVBYX7u/9M5DwxynE1RmoTq/v5MFdAIz2eFiJNNS8+ew9YJ5 qSF4iNDSO1PCz92xM/Uwq+S5IZ+m5Ps9jVWpVroJq++OuB7KC5JO/6J+0E1hMj8+ylP2 ipvf+BjH/o90V5jKdh9axgs4XLB351JR/6tI8ZnjUes2oWw4OY222+mUIuhbT1MYlKqZ CeJ/313dq/bjDEDzDlKGecKrZm9fCcdAQZrYaRJ71X2be0UePJ84tfuzY2J1bWET2031 jAjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=mTXyYAomhVjJ7+iNieUmgqIEYlpcaXWf0G4caK1J72A=; b=F2YVlCpVav7a9EnKKeU83XUbYfHc0+E501t6LbSYuqQ0iv6VMlTKc2ygVnQMcoe1aE KmN5ZDLrEqeh7jWbRL/YrII/6IgT/4GxKCkQhuXb+afA/hmpYUEJZEnfiRvVLAqwRu8S u9CdM9xipUm0uaK2MUC8XKPYpZxkxoLVVNOx+9W6LVuK52kqLA8khVRkAht7M8YVB33m JEPy4CKs+cL1YdVHkv6yyA0Co0GrPaGNa2xDgta+CGnjgUbOJLw2UQ9RnYAtEwT+2ciu EXOzZ0AgNEDQTtoc+zBg4IZ+huN1mS2i9eWBmE66O6ePCbhicormjdbFVwE96Zuci6J7 +Y1A== X-Gm-Message-State: AO0yUKWAZk/OmOO3WpZfxYXFOyt5Z8A4z1iVHdUk0pRbF7Lr0jK9aI48 2Q/jIrErYatB2zfVKaz6V2/yNbvkx0gQkA== X-Google-Smtp-Source: AK7set/UhJalRUCNZc1IlJl/wO2attWnbTVvAcGS3XVmkf7rwu8JPGqkCXaIn/TiF9rtNs3Fmj1SbA== X-Received: by 2002:a5d:42d2:0:b0:2cd:bc79:5431 with SMTP id t18-20020a5d42d2000000b002cdbc795431mr4067206wrr.25.1677762299949; Thu, 02 Mar 2023 05:04:59 -0800 (PST) Received: from [192.168.4.38] ([54.239.6.184]) by smtp.gmail.com with ESMTPSA id a4-20020a5d5704000000b002c559843748sm15437532wrv.10.2023.03.02.05.04.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Mar 2023 05:04:59 -0800 (PST) Content-Type: multipart/mixed; boundary="------------N4rRjejFUmgMdqaUwIlyl00f" Message-ID: <86b7297e-13c0-dca0-a723-c687e3878608@gmail.com> Date: Thu, 2 Mar 2023 14:04:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Fix comments in gistxlogDelete, xl_heap_freeze_page and xl_btree_delete Content-Language: en-US From: "Drouvot, Bertrand" To: PostgreSQL Hackers Cc: Robert Haas References: <80db7836-4415-d54a-64c3-66b88b1430e7@gmail.com> In-Reply-To: <80db7836-4415-d54a-64c3-66b88b1430e7@gmail.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------N4rRjejFUmgMdqaUwIlyl00f Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 1/6/23 11:05 AM, Drouvot, Bertrand wrote: > Hi hackers, > > Please find attached a patch to $SUBJECT. > > The wrong comments have been discovered by Robert in [1]. > > Submitting this here as a separate thread so it does not get lost in the logical decoding > on standby thread. > > [1]: https://www.postgresql.org/message-id/CA%2BTgmoYTTsxP8y6uknZvCBNCRq%2B1FJ4zGbX8Px1TGW459fGsaQ%40mail.gmail.com > > Looking forward to your feedback, > > Regards, > It looks like I did not create a CF entry for this one: fixed with [1]. Also, while at it, adding a commit message in V2 attached. [1]: https://commitfest.postgresql.org/43/4235/ Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com --------------N4rRjejFUmgMdqaUwIlyl00f Content-Type: text/plain; charset=UTF-8; name="v2-0001-Fix-comments-in-gistxlogDelete-xl_heap_freeze_pag.patch" Content-Disposition: attachment; filename*0="v2-0001-Fix-comments-in-gistxlogDelete-xl_heap_freeze_pag.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAwNzVhOGQxYzNkYmMxZWYzMzljMzVmNzE5ZmFlZjc1OGY4NTU2MTRlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBCZXJ0cmFuZCBEcm91dm90IDxiZXJ0cmFuZGRyb3V2 b3QucGdAZ21haWwuY29tPgpEYXRlOiBUaHUsIDIgTWFyIDIwMjMgMTI6NDY6MDEgKzAwMDAK U3ViamVjdDogW1BBVENIIHYyXSBGaXggY29tbWVudHMgaW4gZ2lzdHhsb2dEZWxldGUsIHhs X2hlYXBfZnJlZXplX3BhZ2UgYW5kCiB4bF9idHJlZV9kZWxldGUKCmdpc3R4bG9nRGVsZXRl IGNsYWltcyB0aGF0IE9mZnNldE51bWJlcnMgYXJlIGluIHBheWxvYWQgb2YgYmxrIDAsIHdo aWNoIGlzIG5vdAphcyB0aGV5IGZvbGxvdyB0aGUgbWFpbiBwYXlsb2FkLgoKeGxfaGVhcF9m cmVlemVfcGFnZSBjbGFpbXMgdGhhdCBmcmVlemUgcGxhbnMgYW5kIG9mZnNldCBudW1iZXJz IGZvbGxvdywgYnV0CnRoZXkgZG9uJ3Q6IHRoZXkncmUgaW4gdGhlIGRhdGEgZm9yIGJsb2Nr IDAuCgp4bF9idHJlZV9kZWxldGUgY2xhaW1zIHRoYXQgdGhlIGRhdGEgZm9sbG93cyBidXQg dGhleSBhcmUgYXR0YWNoZWQgdG8gYmxvY2sgMC4KClRoaXMgY29tbWl0IGZpeGVzIHRoZSBy ZWxhdGVkIGNvbW1lbnRzLgotLS0KIHNyYy9pbmNsdWRlL2FjY2Vzcy9naXN0eGxvZy5oICAg IHwgNCArLS0tCiBzcmMvaW5jbHVkZS9hY2Nlc3MvaGVhcGFtX3hsb2cuaCB8IDUgKysrLS0K IHNyYy9pbmNsdWRlL2FjY2Vzcy9uYnR4bG9nLmggICAgIHwgOSArKysrKystLS0KIDMgZmls ZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKIDEwMC4wJSBz cmMvaW5jbHVkZS9hY2Nlc3MvCgpkaWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUvYWNjZXNzL2dp c3R4bG9nLmggYi9zcmMvaW5jbHVkZS9hY2Nlc3MvZ2lzdHhsb2cuaAppbmRleCAwOWY5YjBm OGM2Li4yY2U5MzY2Mjc3IDEwMDY0NAotLS0gYS9zcmMvaW5jbHVkZS9hY2Nlc3MvZ2lzdHhs b2cuaAorKysgYi9zcmMvaW5jbHVkZS9hY2Nlc3MvZ2lzdHhsb2cuaApAQCAtNTIsOSArNTIs NyBAQCB0eXBlZGVmIHN0cnVjdCBnaXN0eGxvZ0RlbGV0ZQogCVRyYW5zYWN0aW9uSWQgc25h cHNob3RDb25mbGljdEhvcml6b247CiAJdWludDE2CQludG9kZWxldGU7CQkvKiBudW1iZXIg b2YgZGVsZXRlZCBvZmZzZXRzICovCiAKLQkvKgotCSAqIEluIHBheWxvYWQgb2YgYmxrIDAg OiB0b2RlbGV0ZSBPZmZzZXROdW1iZXJzCi0JICovCisJLyogVE9ERUxFVEUgT0ZGU0VUIE5V TUJFUiBBUlJBWSBGT0xMT1dTICovCiB9IGdpc3R4bG9nRGVsZXRlOwogCiAjZGVmaW5lIFNp emVPZkdpc3R4bG9nRGVsZXRlCShvZmZzZXRvZihnaXN0eGxvZ0RlbGV0ZSwgbnRvZGVsZXRl KSArIHNpemVvZih1aW50MTYpKQpkaWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUvYWNjZXNzL2hl YXBhbV94bG9nLmggYi9zcmMvaW5jbHVkZS9hY2Nlc3MvaGVhcGFtX3hsb2cuaAppbmRleCA4 Y2IwZDhkYTE5Li5hMmM2N2QxY2QzIDEwMDY0NAotLS0gYS9zcmMvaW5jbHVkZS9hY2Nlc3Mv aGVhcGFtX3hsb2cuaAorKysgYi9zcmMvaW5jbHVkZS9hY2Nlc3MvaGVhcGFtX3hsb2cuaApA QCAtMzQ1LDggKzM0NSw5IEBAIHR5cGVkZWYgc3RydWN0IHhsX2hlYXBfZnJlZXplX3BhZ2UK IAlUcmFuc2FjdGlvbklkIHNuYXBzaG90Q29uZmxpY3RIb3Jpem9uOwogCXVpbnQxNgkJbnBs YW5zOwogCi0JLyogRlJFRVpFIFBMQU5TIEZPTExPVyAqLwotCS8qIE9GRlNFVCBOVU1CRVIg QVJSQVkgRk9MTE9XUyAqLworCS8qCisJICogSW4gcGF5bG9hZCBvZiBibGsgMCA6IEZSRUVa RSBQTEFOUyBhbmQgT0ZGU0VUIE5VTUJFUiBBUlJBWQorCSAqLwogfSB4bF9oZWFwX2ZyZWV6 ZV9wYWdlOwogCiAjZGVmaW5lIFNpemVPZkhlYXBGcmVlemVQYWdlIChvZmZzZXRvZih4bF9o ZWFwX2ZyZWV6ZV9wYWdlLCBucGxhbnMpICsgc2l6ZW9mKHVpbnQxNikpCmRpZmYgLS1naXQg YS9zcmMvaW5jbHVkZS9hY2Nlc3MvbmJ0eGxvZy5oIGIvc3JjL2luY2x1ZGUvYWNjZXNzL25i dHhsb2cuaAppbmRleCBlZGQxMzMzZDliLi5lN2E5NzExNzY3IDEwMDY0NAotLS0gYS9zcmMv aW5jbHVkZS9hY2Nlc3MvbmJ0eGxvZy5oCisrKyBiL3NyYy9pbmNsdWRlL2FjY2Vzcy9uYnR4 bG9nLmgKQEAgLTIzNiw5ICsyMzYsMTIgQEAgdHlwZWRlZiBzdHJ1Y3QgeGxfYnRyZWVfZGVs ZXRlCiAJdWludDE2CQluZGVsZXRlZDsKIAl1aW50MTYJCW51cGRhdGVkOwogCi0JLyogREVM RVRFRCBUQVJHRVQgT0ZGU0VUIE5VTUJFUlMgRk9MTE9XICovCi0JLyogVVBEQVRFRCBUQVJH RVQgT0ZGU0VUIE5VTUJFUlMgRk9MTE9XICovCi0JLyogVVBEQVRFRCBUVVBMRVMgTUVUQURB VEEgKHhsX2J0cmVlX3VwZGF0ZSkgQVJSQVkgRk9MTE9XUyAqLworCS8qCisJICogSW4gcGF5 bG9hZCBvZiBibGsgMCA6CisJICogLSBERUxFVEVEIFRBUkdFVCBPRkZTRVQgTlVNQkVSUwor CSAqIC0gVVBEQVRFRCBUQVJHRVQgT0ZGU0VUIE5VTUJFUlMKKwkgKiAtIFVQREFURUQgVFVQ TEVTIE1FVEFEQVRBICh4bF9idHJlZV91cGRhdGUpIEFSUkFZCisJICovCiB9IHhsX2J0cmVl X2RlbGV0ZTsKIAogI2RlZmluZSBTaXplT2ZCdHJlZURlbGV0ZQkob2Zmc2V0b2YoeGxfYnRy ZWVfZGVsZXRlLCBudXBkYXRlZCkgKyBzaXplb2YodWludDE2KSkKLS0gCjIuMzQuMQoK --------------N4rRjejFUmgMdqaUwIlyl00f--