Feedback-ID: i131946ab:Fastmail
Content-Type: multipart/mixed; boundary="------------nukGtiDA5ccnMrvxXRBxiokl"
Message-ID: <86c5b4c4-0ccf-0996-8fb8-24d348eabe13@enterprisedb.com>
Date: Mon, 8 May 2023 17:48:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.1
Subject: Re: Add standard collation UNICODE
Content-Language: en-US
To: Daniel Verite <daniel@manitou-mail.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <49417853-7bdd-4b23-a4e9-04c7aff33821@manitou-mail.org>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <49417853-7bdd-4b23-a4e9-04c7aff33821@manitou-mail.org>
Archived-At: <https://www.postgresql.org/message-id/86c5b4c4-0ccf-0996-8fb8-24d348eabe13%40enterprisedb.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------nukGtiDA5ccnMrvxXRBxiokl
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 27.04.23 13:44, Daniel Verite wrote:
> This collation has an empty pg_collation.collversion column, instead
> of being set to the same value as "und-x-icu" to track its version.

> The original patch implements this as an INSERT in which it would be easy to
> fix I guess, but in current HEAD it comes as an entry in
> include/catalog/pg_collation.dat:
> 
> { oid => '963',
>    descr => 'sorts using the Unicode Collation Algorithm with default
> settings',
>    collname => 'unicode', collprovider => 'i', collencoding => '-1',
>    colliculocale => 'und' },
> 
> Should it be converted back into an INSERT or better left
> in this file and collversion being updated afterwards?

How about we do it with an UPDATE command.  We already do this for 
pg_database in a similar way.  See attached patch.

--------------nukGtiDA5ccnMrvxXRBxiokl
Content-Type: text/plain; charset=UTF-8;
 name="0001-initdb-Set-collversion-for-standard-collation-UNICOD.patch"
Content-Disposition: attachment;
 filename*0="0001-initdb-Set-collversion-for-standard-collation-UNICOD.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSA5MWYyYWZmMDRmOWJmMTM3ZTRhYzZlN2RmNjI0ZGRlNzcwNTAzYmZkIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogTW9uLCA4IE1heSAyMDIzIDE3OjQ1OjQ2ICswMjAwClN1YmplY3Q6
IFtQQVRDSF0gaW5pdGRiOiBTZXQgY29sbHZlcnNpb24gZm9yIHN0YW5kYXJkIGNvbGxhdGlv
biBVTklDT0RFCgpEaXNjdXNzaW9uOiBodHRwczovL3d3dy5wb3N0Z3Jlc3FsLm9yZy9tZXNz
YWdlLWlkLzQ5NDE3ODUzLTdiZGQtNGIyMy1hNGU5LTA0YzdhZmYzMzgyMUBtYW5pdG91LW1h
aWwub3JnCi0tLQogc3JjL2Jpbi9pbml0ZGIvaW5pdGRiLmMgfCA3ICsrKysrKysKIDEgZmls
ZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9zcmMvYmluL2luaXRk
Yi9pbml0ZGIuYyBiL3NyYy9iaW4vaW5pdGRiL2luaXRkYi5jCmluZGV4IDJjMjA4ZWFkMDEu
LjYzMmY2YzljNzIgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vaW5pdGRiL2luaXRkYi5jCisrKyBi
L3NyYy9iaW4vaW5pdGRiL2luaXRkYi5jCkBAIC0xNjk1LDYgKzE2OTUsMTMgQEAgc2V0dXBf
ZGVzY3JpcHRpb24oRklMRSAqY21kZmQpCiBzdGF0aWMgdm9pZAogc2V0dXBfY29sbGF0aW9u
KEZJTEUgKmNtZGZkKQogeworCS8qCisJICogU2V0IHRoZSBjb2xsYXRpb24gdmVyc2lvbiBm
b3IgY29sbGF0aW9ucyBkZWZpbmVkIGluIHBnX2NvbGxhdGlvbi5kYXQsCisJICogZXhjZXB0
IHRoZSBvbmVzIHdoZXJlIHdlIGtub3cgdGhhdCB0aGUgY29sbGF0aW9uIGJlaGF2aW9yIHdp
bGwgbmV2ZXIKKwkgKiBjaGFuZ2UuCisJICovCisJUEdfQ01EX1BVVFMoIlVQREFURSBwZ19j
b2xsYXRpb24gU0VUIGNvbGx2ZXJzaW9uID0gcGdfY29sbGF0aW9uX2FjdHVhbF92ZXJzaW9u
KG9pZCkgV0hFUkUgY29sbG5hbWUgPSAndW5pY29kZSc7XG5cbiIpOworCiAJLyogSW1wb3J0
IGFsbCBjb2xsYXRpb25zIHdlIGNhbiBmaW5kIGluIHRoZSBvcGVyYXRpbmcgc3lzdGVtICov
CiAJUEdfQ01EX1BVVFMoIlNFTEVDVCBwZ19pbXBvcnRfc3lzdGVtX2NvbGxhdGlvbnMoJ3Bn
X2NhdGFsb2cnKTtcblxuIik7CiB9Ci0tIAoyLjQwLjAKCg==

--------------nukGtiDA5ccnMrvxXRBxiokl--