Subject: Re: Fix typos and inconsistencies for HEAD (take 9)
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <7ab243e0-116d-3e44-d120-76b3df7abefd@gmail.com>
 <20190805031521.GA1740@paquier.xyz>
From: Alexander Lakhin <exclusion@gmail.com>
Message-ID: <86f078b7-3d3f-ceee-66ad-c1f3a90a6811@gmail.com>
Date: Mon, 5 Aug 2019 06:44:46 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <20190805031521.GA1740@paquier.xyz>
Content-Type: multipart/mixed;
 boundary="------------D8D42FF131E64A6950544370"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------D8D42FF131E64A6950544370
Content-Type: multipart/alternative;
 boundary="------------13837A1B91E8CF9A515FF75D"


--------------13837A1B91E8CF9A515FF75D
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit

Hello Michael,

05.08.2019 6:15, Michael Paquier wrote:
>> 9.41. OWNER_TO -> OWNER TO
> This one needs a back-patch.  I'll fix that separately.
>
I believe that all the fixes in doc/ should be back-patched too. If it's
not too late, I can produce such patches for the nearest releases.
>> 9.75. Point-in-Time -> Point-In-Time
> Why?  The original looks correct to me.
acronyms.sgml contains such spelling:
    <term><acronym>PITR</acronym></term>
    <listitem>
     <para>
      <link linkend="continuous-archiving">Point-In-Time
      Recovery</link> (Continuous Archiving)
     </para>
>> Also, please fix my typo (from the previous set), that was somehow
>> silted through a double check.
> Which one is that, please?  It is likely possible that some obvious
> stuff has been forgotten.
"It the username successfully retrieved,..." (fix_for_fix_8.15.patch)
> Committed a large bunch of this stuff.  Please note that the
> indentation was incorrect in a couple of places, including the change
> in src/tools/msvc/.
Thank you. I will check my Tab settings next time.

Best regards,
Alexander

--------------13837A1B91E8CF9A515FF75D
Content-Type: text/html; charset=windows-1252
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html;
      charset=windows-1252">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <div class="moz-cite-prefix">Hello Michael,<br>
      <br>
      05.08.2019 6:15, Michael Paquier wrote:<br>
      <blockquote type="cite"
        cite="mid:20190805031521.GA1740@paquier.xyz">
        <blockquote type="cite" style="color: #000000;">
          <pre class="moz-quote-pre" wrap="">9.41. OWNER_TO -&gt; OWNER TO
</pre>
        </blockquote>
        <pre class="moz-quote-pre" wrap="">This one needs a back-patch.  I'll fix that separately.

</pre>
      </blockquote>
      I believe that all the fixes in doc/ should be back-patched too.
      If it's not too late, I can produce such patches for the nearest
      releases.<br>
    </div>
    <blockquote type="cite" cite="mid:20190805031521.GA1740@paquier.xyz">
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">9.75. Point-in-Time -&gt; Point-In-Time
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">Why?  The original looks correct to me.</pre>
    </blockquote>
    acronyms.sgml contains such spelling:<br>
        &lt;term&gt;&lt;acronym&gt;PITR&lt;/acronym&gt;&lt;/term&gt;<br>
        &lt;listitem&gt;<br>
         &lt;para&gt;<br>
          &lt;link linkend="continuous-archiving"&gt;Point-In-Time<br>
          Recovery&lt;/link&gt; (Continuous Archiving)<br>
         &lt;/para&gt;<br>
    <blockquote type="cite" cite="mid:20190805031521.GA1740@paquier.xyz">
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">Also, please fix my typo (from the previous set), that was somehow
silted through a double check.
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">Which one is that, please?  It is likely possible that some obvious
stuff has been forgotten.</pre>
    </blockquote>
    "It the username successfully retrieved,..."
    (fix_for_fix_8.15.patch)<br>
    <blockquote type="cite" cite="mid:20190805031521.GA1740@paquier.xyz">
      <pre class="moz-quote-pre" wrap="">Committed a large bunch of this stuff.  Please note that the
indentation was incorrect in a couple of places, including the change
in src/tools/msvc/.</pre>
    </blockquote>
    Thank you. I will check my Tab settings next time.<br>
    <br>
    Best regards,<br>
    Alexander<br>
  </body>
</html>

--------------13837A1B91E8CF9A515FF75D--

--------------D8D42FF131E64A6950544370
Content-Type: text/x-patch;
 name="fix_for_fix_8.15.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="fix_for_fix_8.15.patch"

diff --git a/src/backend/libpq/auth.c b/src/backend/libpq/auth.c
index 5fb1f1b7d7..3713dd2884 100644
--- a/src/backend/libpq/auth.c
+++ b/src/backend/libpq/auth.c
@@ -1797,7 +1797,7 @@ interpret_ident_response(const char *ident_response,
 /*
  *	Talk to the ident server on "remote_addr" and find out who
  *	owns the tcp connection to "local_addr"
- *	It the username successfully retrieved, check the usermap.
+ *	If the username successfully retrieved, check the usermap.
  *
  *	XXX: Using WaitLatchOrSocket() and doing a CHECK_FOR_INTERRUPTS() if the
  *	latch was set would improve the responsiveness to timeouts/cancellations.

--------------D8D42FF131E64A6950544370--