From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Zhihong Yu <zyu@yugabyte.com>, Andres Freund <andres@anarazel.de>,
        Daniel Gustafsson <daniel@yesql.se>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: A qsort template
In-reply-to: 
 <CA+hUKGKCV5w-9oJHE1+Aowwr1kp-A7UtF_2YKbRPDAUCHj0nxg@mail.gmail.com>
References: 
 <CA+hUKGJ2-eaDqAum5bxhpMNhvuJmRDZxB_Tow0n-gse+HG0Yig@mail.gmail.com>
 <0F9ECBA9-1DF2-4C38-BB58-B17EEE6C7B3A@yesql.se>
 <CA+hUKGJhOtjQH+wjCodtJzHAFCAPYyt6Qm9E1mUoJph42qo1hg@mail.gmail.com>
 <20210311185847.zwb2rf3n4wzelkba@alap3.anarazel.de>
 <CA+hUKGLqmksGRKQRF6qkih6jV_d9qVrrk4wh5F_EgTXyRGeCyw@mail.gmail.com>
 <CA+hUKGKztHEWm676csTFjYzortziWmOcf8HDss2Zr0muZ2xfEg@mail.gmail.com>
 <CALNJ-vRSvudAbdY-DChFv8C0-dJYD3FamX4FpW9A2xivKuB83A@mail.gmail.com>
 <CA+hUKGKWR3_-sqTE8BSrSy0kp0WJeKQ1ffyYxEKuykA7vmG9uQ@mail.gmail.com>
 <CA+hUKGLAfouP-rUpik45Z_KPM5+oxrX_564bLfiZPX4f25MYbA@mail.gmail.com>
 <CALNJ-vQjQ_Kj0dLOeYFApbdbS2r8hW=VtYdan-vZ==H6uom_fA@mail.gmail.com>
 <CA+hUKGKCV5w-9oJHE1+Aowwr1kp-A7UtF_2YKbRPDAUCHj0nxg@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Thu, 17 Jun 2021 09:54:21 +1200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <870659.1623886818.1@sss.pgh.pa.us>
Date: Wed, 16 Jun 2021 19:40:18 -0400
Message-ID: <870660.1623886818@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/870660.1623886818%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> Hmm, well it was only recently damaged by commit def5b065, and that's
> because I'd forgotten to put ST_ELEMENT_TYPE into typedefs.list, and I
> was correcting that in this patch.

If ST_ELEMENT_TYPE isn't recognized as a typedef by the buildfarm's
typedef collectors, this sort of manual addition to typedefs.list
is not going to survive the next pgindent run.  No, I will NOT
promise to manually add it back every time.

We do already have special provision for injecting additional typedefs
in the pgindent script, so one possibility is to add it there:

-my @additional = ("bool\n");
+my @additional = ("bool\nST_ELEMENT_TYPE\n");

On the whole I'm not sure that this is a big enough formatting
issue to justify a special hack, though.  Is there any more than
the one line that gets misformatted?

			regards, tom lane