Subject: Re: Dumping/restoring fails on inherited generated column
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
 Tom Lane <tgl@sss.pgh.pa.us>
References: <15830.1575468847@sss.pgh.pa.us>
 <fd559544-274c-f514-d8bf-358d2c539455@2ndquadrant.com>
 <31905.1575491779@sss.pgh.pa.us>
 <d6ebcc2e-3e6f-6915-6616-70ef665aed66@2ndquadrant.com>
 <24369.1580758361@sss.pgh.pa.us>
 <b1c831dd-d520-5e7f-0304-0eeed39c9996@2ndquadrant.com>
 <CA+fd4k4cHKUmEyHiPHx0QL3T-DXAP8O1CP-hUvo1WX6RwNC=tA@mail.gmail.com>
 <3f272982-0e0d-17a1-3fb6-fedc74197676@2ndquadrant.com>
 <c9848634-76c1-3c21-fc19-f1b7eebb640f@2ndquadrant.com>
 <3169466.1594841366@sss.pgh.pa.us>
 <CA+fd4k4fck6xzsF8mPWeVSZFBLtiA2cQxrPqBaYcoZGc+hZ=JQ@mail.gmail.com>
 <CA+fd4k6pLzrZDQsdsxcS06AwGRf1DgwOw84sFq9oXNw+83nB1g@mail.gmail.com>
 <bf846641-b695-d095-f3d1-f362d58c7296@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Organization: 2ndQuadrant
Message-ID: <87182204-d0ab-abd1-15fc-9da4e251efc6@2ndquadrant.com>
Date: Tue, 3 Nov 2020 15:53:10 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <bf846641-b695-d095-f3d1-f362d58c7296@2ndquadrant.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-09-25 15:07, Peter Eisentraut wrote:
> We could probably fix this by having ALTER TABLE ONLY / DROP EXPRESSION
> update the attlocal column of direct children to true, to make the
> catalog state look like something that can be restored.  However, that's
> a fair amount of complicated code, so for now I propose to just prohibit
> this command, meaning you can't use ONLY in this command if there are
> children.  This is new in PG13, so this change would have very limited
> impact in practice.

With the minor releases coming up, I have committed this patch and will 
work on getting the remaining pg_dump issues fixed as well.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services