Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1raYPu-00AIei-Te for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Feb 2024 09:52:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1raYPs-00CA85-WF for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Feb 2024 09:52:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1raYPs-00CA7x-NN for pgsql-hackers@lists.postgresql.org; Thu, 15 Feb 2024 09:52:28 +0000 Received: from m15.mail.163.com ([45.254.50.220]) by magus.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1raYPo-007J6W-9R for pgsql-hackers@lists.postgresql.org; Thu, 15 Feb 2024 09:52:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version: Content-Type; bh=fKSd1HZYZ87ivbp0IF3nbZ7KerkKePgeTftjPkVpoWk=; b=D8TEpL++Pfx+t44xFYyHKKdPvYS4SNI8CMHgFyQPchNwb29wn2nqa59PS7N2m/ ZEk2vkOExMNXVIEffHtMjL27W/Lg/7E7yPDKpC5wl6yd3DzU7/FcF5pRS6p2dGSU 52Fb2zAoOq8lAPvI67cevt/RwfMxZHqKTZ1kzDiJ9loDo= Received: from 8235eee8a2a0 (unknown [140.205.118.89]) by gzga-smtp-mta-g0-4 (Coremail) with SMTP id _____wC3n6rS3s1lDaeREA--.37056S3; Thu, 15 Feb 2024 17:52:18 +0800 (CST) References: <247851.1668293143@sss.pgh.pa.us> <602d6b44-c734-4f7f-8999-99b6cac9bf17@yandex.ru> <00de47dd-7a38-4225-a47e-65a8ba6de8d3@yandex.ru> User-agent: mu4e 1.10.7; emacs 29.1 From: Andy Fan To: Alexander Korotkov Cc: vignesh C , Alena Rybakina , Andy Fan , pgsql-hackers , Tom Lane , Richard Guo , Andrey Lepikhov , pgsql-hackers@lists.postgresql.org Subject: Re: A new strategy for pull-up correlated ANY_SUBLINK Date: Thu, 15 Feb 2024 17:51:28 +0800 In-reply-to: Message-ID: <871q9ehx66.fsf@163.com> MIME-Version: 1.0 Content-Type: text/plain X-CM-TRANSID:_____wC3n6rS3s1lDaeREA--.37056S3 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUYiihUUUUU X-Originating-IP: [140.205.118.89] X-CM-SenderInfo: x2klx3xlid0iqsrtqiywtou0bp/1tbiVB2FU2VOBe7qkAABsk List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Alexander, > Hi! > >> If the changes of Alena are ok, can you merge the changes and post an >> updated version so that CFBot can apply the patch and verify the >> changes. As currently CFBot is trying to apply only Alena's changes >> and failing with the following at [1]: > > I think this is a very nice and pretty simple optimization. I've > merged the changes by Alena, and slightly revised the code changes in > convert_ANY_sublink_to_join(). I'm going to push this if there are no > objections. Thanks for picking up this! I double checked the patch, it looks good to me. -- Best Regards Andy Fan