Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oppSW-0005b0-D0 for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Nov 2022 11:29:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oppSV-0005VX-3D for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Nov 2022 11:29:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oppSU-0005VO-72 for pgsql-hackers@lists.postgresql.org; Tue, 01 Nov 2022 11:29:30 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oppSQ-0003Wl-Ke for pgsql-hackers@lists.postgresql.org; Tue, 01 Nov 2022 11:29:29 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 4996E3200987; Tue, 1 Nov 2022 07:29:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 01 Nov 2022 07:29:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilmari.org; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1667302163; x= 1667388563; bh=Qyx/nfigkXmdIU70Do7JbMebOp2Vb3+U14pRhI4v6s8=; b=N hRJpnOQCxgieRdnBh+1es612lyixGVp6qKw+l80YcYW0RN/YxdXO2Kz4/KvRF22E MPSmOY4oMRe13zd3wvG/ylXZOslPBqM6lZp+++DVYt+G2OPCP3K7wWRwhtNdZ1Cu LE78DfEk8bUBaniLnrMLPtMU06M2LtQt9l1U9/Y3O0yC5kYJn+BSgf/RVgHXyX89 TFxVwKmOHIyHy1vqy96abgyisj2EuYRf1EEoMLbzAZveYy+A77XwGIXM8yRauZOq Hqs+9F74sNtNmHSj+tcHCNuOZ3V7YyaIdUcTOXITBKX0dRaqABlsvzjzqezlpGBJ Ml5JwiLrdv8QM5GBtr2YQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1667302163; x= 1667388563; bh=Qyx/nfigkXmdIU70Do7JbMebOp2Vb3+U14pRhI4v6s8=; b=a 4wnE+WOI8VvH1Kxh4fjOafWSfc+cge5CtvE+ALpRmtthsiauBvqcs55NTgM5UVeJ t9NT4eSGXCkBT+lRVBq3JgDh1fW5GYZez5lfs8nAuLHhOhSp3BidGu/7ea5IBvbs 8eY1QHxKmxlF/FKa6imKpaLxEGt8CnuYNKxjeM9JiFB8NWUKRPYKTTF94F4SjUJi 6kCeuoo9+0Lywf6qGxVM2Yz4IbL6z6Yh3w4CvnKHV8nbR/fnlbhN2aaxeR/H3kG3 /oBHSC6Dxbzm+QLwjWZFvZ8n13BYCrhZirwz2nFcGv8p7x5TyrFhlVkahCZ+BGPJ brKsm2QSfjcOj3odrgl/g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrudehgddvkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufhfffgjkfgfgggtgfesthekredttderjeenucfhrhhomhepffgrghhf ihhnnhcukfhlmhgrrhhiucforghnnhhsnohkvghruceoihhlmhgrrhhisehilhhmrghrih drohhrgheqnecuggftrfgrthhtvghrnhephfeuudduhefgffeijeehuedtleffledvledv hfeihfevkeejuddtleegfeejueelnecuffhomhgrihhnpehpohhsthhgrhgvshhqlhdroh hrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehi lhhmrghrihesihhlmhgrrhhirdhorhhg X-ME-Proxy: Feedback-ID: i1ff147bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 1 Nov 2022 07:29:23 -0400 (EDT) From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= To: Peter Eisentraut Cc: PostgreSQL Hackers Subject: Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns References: <87mta1jfax.fsf@wibble.ilmari.org> <87k052jx35.fsf@wibble.ilmari.org> <27b42f79-2743-d806-faf0-23c6ac758a52@enterprisedb.com> Date: Tue, 01 Nov 2022 11:29:21 +0000 In-Reply-To: <27b42f79-2743-d806-faf0-23c6ac758a52@enterprisedb.com> (Peter Eisentraut's message of "Tue, 1 Nov 2022 12:19:54 +0100") Message-ID: <871qqmkj5a.fsf@wibble.ilmari.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Eisentraut writes: > On 14.10.22 16:31, Dagfinn Ilmari Mannsåker wrote: >>> I noticed that psql has no tab completion around identity columns in >>> ALTER TABLE, so here's some patches for that. >> Added to the next commit fest: >> https://commitfest.postgresql.org/40/3947/ > > Committed. Thanks! - ilmari