From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>,  Dipesh Pandit
 <dipesh.pandit@gmail.com>,  Andres Freund <andres@anarazel.de>,  Jeevan
 Ladhe <jeevanladhe.os@gmail.com>,  Alvaro Herrera
 <alvherre@alvh.no-ip.org>,  "Shinoda, Noriyoshi (PN Japan FSIP)"
 <noriyoshi.shinoda@hpe.com>,  Abhijit Menon-Sen <ams@toroid.org>,  Dmitry
 Dolgov <9erthalion6@gmail.com>,  Jeevan Ladhe
 <jeevan.ladhe@enterprisedb.com>,  Mark Dilger
 <mark.dilger@enterprisedb.com>,  "pgsql-hackers@postgresql.org"
 <pgsql-hackers@postgresql.org>,  tushar <tushar.ahuja@enterprisedb.com>
Subject: Re: refactoring basebackup.c (zstd workers)
References: 
 <CA+TgmoaYrNxoGB8x_7Fk5uKXfbyMVAdSXTnfQN-1zu_3gB_v=Q@mail.gmail.com>
	<20220314171152.GU28503@telsasoft.com>
	<CA+TgmoYfV1ASq0QVR1QHaJnXfr+fPLoPByQL1SfWqjUuKtX_UA@mail.gmail.com>
	<CA+TgmoYvpetyRAbbg1M8b3-iHsaN4nsgmWPjOENu5-doHuJ7fA@mail.gmail.com>
	<20220317194130.GM28503@telsasoft.com>
	<CA+TgmoaaDXOT+vFDcPrnXjPTU7oFPY2_pkeQFTdSGJfrqO2LNQ@mail.gmail.com>
	<20220320194050.GX28503@telsasoft.com>
	<CA+TgmoY90uUaqtx133BsH26ZabTRK-J5VoOsGga_wRw8+HdWpQ@mail.gmail.com>
	<20220321131833.GB28503@telsasoft.com>
	<CA+TgmoZz-F1pA1Vv=-6FOPWuS1eFi2ifNyySV4u6pW0+FBeG-g@mail.gmail.com>
	<20220321182256.GC28503@telsasoft.com>
	<CA+TgmoYJ=9Y=+fJ9WyAXAExTmpArCZEdRu1iVQ_2je+heTZGrg@mail.gmail.com>
Date: Mon, 21 Mar 2022 18:41:33 +0000
In-Reply-To: 
 <CA+TgmoYJ=9Y=+fJ9WyAXAExTmpArCZEdRu1iVQ_2je+heTZGrg@mail.gmail.com>
	(Robert Haas's message of "Mon, 21 Mar 2022 14:25:52 -0400")
Message-ID: <871qyvrvvm.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Archived-At: 
 <https://www.postgresql.org/message-id/871qyvrvvm.fsf%40wibble.ilmari.org>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:

> On Mon, Mar 21, 2022 at 2:22 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
>> + * during parsing, and will otherwise contain a an appropriate error message.
>
> OK, thanks. v4 attached.

I haven't read the whole patch, but I noticed an omission in the
documentation changes:

> diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
> index 9178c779ba..00c593f1af 100644
> --- a/doc/src/sgml/protocol.sgml
> +++ b/doc/src/sgml/protocol.sgml
> @@ -2731,14 +2731,24 @@ The commands accepted in replication mode are:
>         <varlistentry>
> -        <term><literal>COMPRESSION_LEVEL</literal> <replaceable>level</replaceable></term>
> +        <term><literal>COMPRESSION_DETAIL</literal> <replaceable>detail</replaceable></term>
>          <listitem>
>           <para>
>            Specifies the compression level to be used.

This is no longer the accurate. How about something like like "Specifies
details of the chosen compression method"?

- ilmari