Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1grfOT-0001QH-G3
	for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Feb 2019 08:50:50 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1grfOR-0007AM-SS
	for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Feb 2019 08:50:47 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <a.sher@postgrespro.ru>)
	id 1grfOR-00079z-DL
	for pgsql-hackers@lists.postgresql.org; Thu, 07 Feb 2019 08:50:47 +0000
Received: from mail.postgrespro.ru ([93.174.131.138])
	by makus.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <a.sher@postgrespro.ru>)
	id 1grfOI-0003p8-JA
	for pgsql-hackers@postgresql.org; Thu, 07 Feb 2019 08:50:45 +0000
Received: from localhost (localhost [127.0.0.1])
	by mail.postgrespro.ru (Postfix) with ESMTP id 87B6C21C8C5C;
	Thu,  7 Feb 2019 11:50:35 +0300 (MSK)
X-Virus-Scanned: Debian amavisd-new at postgrespro.ru
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[]
	autolearn=unavailable
Received: from ars-thinkpad (gw.postgrespro.ru [93.174.131.141])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client did not present a certificate)
	by mail.postgrespro.ru (Postfix) with ESMTPSA id 11DC321C8ADC;
	Thu,  7 Feb 2019 11:50:35 +0300 (MSK)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru;
	s=mail; t=1549529435;
	bh=kR8grHOn4i9jmMcCT7vFPfQqEgkYz4U0TbfaKJkkK3E=;
	h=References:From:To:Cc:Subject:In-reply-to:Date;
	b=GPQkb8f5bS4Zz5DBHsKgbhPMDYYRCilv5AKncGgF9dVQB8Ehf82oMz5JjQfGmr6nG
	 1BuEXHtp9kFX+0khpCNsi3hKOqHvRC8sMXyyK1F9/i1yrpaK9E1HbECYK0XH50NB3o
	 wzZF5b6dKReNUH48UQwFVwyZxPKEUfJwqSlyUb/I=
References: <8736p18e7c.fsf@ars-thinkpad>
 <20190206163050.GA22952@alvherre.pgsql>
User-agent: mu4e 1.1.0; emacs 26.0.50
From: Arseny Sher <a.sher@postgrespro.ru>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
 Alexander Lakhin <a.lakhin@postgrespro.ru>
Subject: Re: Too rigorous assert in reorderbuffer.c
In-reply-to: <20190206163050.GA22952@alvherre.pgsql>
Date: Thu, 07 Feb 2019 11:50:29 +0300
Message-ID: <871s4k7zje.fsf@ars-thinkpad>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk


Alvaro Herrera <alvherre@2ndquadrant.com> writes:

> On 2019-Feb-06, Arseny Sher wrote:
>
>>
>> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>>
>> > note the additional pg_temp_XYZ row in the middle.  This is caused by
>> > the rewrite in ALTER TABLE.  Peter E fixed that in Pg11 in commit
>> > 325f2ec55; I don't think there's much to do in the backbranches other
>> > than hide the pesky record to avoid it breaking the test.
>>
>> Oh, I see. Let's just remove the first insertion then, as in attached.
>> I've tested it on master and on 9.4.
>
> Ah, okay.  Does the test still fail when run without the code fix?

Yes. The problem here is overriding cmax of catalog (pg_attribute in the
test) tuples, so it fails without any data at all.


--
Arseny Sher
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company