From: Sergey Burladyan <eshkinkot@gmail.com>
To: Bruce Momjian <bruce@momjian.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>,
  Amit Kapila <amit.kapila16@gmail.com>,
  Dmitriy Sarafannikov <dsarafannikov@yandex.ru>,
  Vladimir Borodin <root@simply.name>
Subject: Re: Broken hint bits (freeze)
References: <87mv98af8j.fsf@seb.koffice.internal>
	<CAA4eK1JB=5gHNhRWgtVcqCQbUzGwR2LM9msYBQVULDfA+1ugUA@mail.gmail.com>
	<20170616164641.GP11450@momjian.us> <87fuezalc3.fsf@seb.koffice.internal>
	<CAA4eK1KMxzg_q2-0rMRh22EMWGutQ0QbCtMqc_5GeuNVyJ8kmA@mail.gmail.com>
	<20170619222113.GF3180@momjian.us>
	<CAJ2ymdg=0knii-bavVLpKEGc9DanaZC+UXjnipx_n-gFvOkdcg@mail.gmail.com>
	<20170620025919.GA28277@momjian.us> <20170620033726.GB28277@momjian.us>
	<87h8zb6kbx.fsf@seb.koffice.internal> <20170620143643.GA24975@momjian.us>
Date: Tue, 20 Jun 2017 18:42:58 +0300
In-Reply-To: <20170620143643.GA24975@momjian.us> (Bruce Momjian's message of
	"Tue, 20 Jun 2017 10:36:43 -0400")
Message-ID: <871sqe7ji5.fsf@seb.koffice.internal>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Bruce Momjian <bruce@momjian.us> writes:

> On Tue, Jun 20, 2017 at 01:10:26PM +0300, Sergey Burladyan wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > > Uh, as I understand it the rsync is going to copy the missing WAL file
> > > > from the new master to the standby, right, and I think pg_controldata
> > > > too, so it should be fine.  Have you tested to see if it fails?
> > 
> > It need old WAL files from old version for correct restore heap
> > files. New WAL files from new version does not have this information.
> > 
> > > The point is that we are checking the "Latest checkpoint location" to
> > > make sure all the WAL was replayed.   We are never going to start the
> > > old standby server.  Rsync is going to copy the missing/changed files.
> > 
> > Only if missing/changed files changed in size, because rsync run with
> > --size-only it does not copy changed files with same size.
>
> I am sorry but I am not understanding.  Step 10.b says:
>
> 	10.b Make sure the new standby data directories do not exist
> 	
> 	Make sure the new standby data directories do not exist or are empty. If
> 	initdb was run, delete the standby server data directories.
>
> so the _entire_ new data directory is empty before rsync is run, meaning
> that it is an exact copy of the new master.

Yes, new data directory at standby is empty, but you missed old data
directory at standby which is hardlink'ed by rsync into new as at master.

rsync run with _three_ arguments and with --hard-links option:
rsync --archive --delete --hard-links --size-only old_pgdata new_pgdata remote_dir
(remote_dir is parent directory for old and new data at standby)

In this mode rsync compare not only new_pgdata with new empty data
directory at standby, but also compare it with old data directory from
standby and with --size-only it doing this compare only by the file
existence or file size.

If file at standby in old data directory is different from same file at
master, but it have same size, it will be hardlinked into new data
directory at standby and does not copied from master.

-- 
Sergey Burladyan


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers