Content-Type: multipart/mixed; boundary="------------Z0ZFYIlVESlli1mWptzW2EBu"
Message-ID: <8733e942-56fc-4542-9351-63f213f7e23c@pgbackrest.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Improve checks for GUC recovery_target_xid
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>,
 =?UTF-8?Q?H=C3=BCseyin_Demir?= <huseyin.d3r@gmail.com>,
 Pg Hackers <pgsql-hackers@postgresql.org>
References: <f14463ab-990b-4ae9-a177-998d2677aae0@pgbackrest.org>
 <CAHGQGwEnakTrosMp3Y=Trya4MTC-h8Lqx3FDU1mOALRQ0rz59Q@mail.gmail.com>
 <9e8b7ee9-4a16-477a-baa5-0cdf37a04798@pgbackrest.org>
 <CAHGQGwG44vZbSoBmg076G+xkR6n=Tj2=q+fVkfP7yEsyF1daFA@mail.gmail.com>
 <c2e97e35-1227-4351-8faa-fa95208f6cf9@pgbackrest.org>
 <aakAmNjKyBWRU1vR@paquier.xyz>
 <e6a27751-8c91-4bff-ba07-2e97de99e34f@pgbackrest.org>
 <CAHGQGwEYYad_=fiBkt8HZ=aknXoCUx=2cL7UwSQSYM3nozHMyg@mail.gmail.com>
 <bc089939-a889-4fd4-bad8-42cc071cd58e@pgbackrest.org>
 <CAHGQGwGuyb--9MBJX__FVJH1=ny0Jh1H+j0Z-_z-28VZy9hK8g@mail.gmail.com>
Content-Language: en-US
From: David Steele <david@pgbackrest.org>
In-Reply-To: 
 <CAHGQGwGuyb--9MBJX__FVJH1=ny0Jh1H+j0Z-_z-28VZy9hK8g@mail.gmail.com>
Date: Thu,  5 Mar 2026 13:32:50 +0000 (UTC)
Archived-At: 
 <https://www.postgresql.org/message-id/8733e942-56fc-4542-9351-63f213f7e23c%40pgbackrest.org>
Precedence: bulk

This is a multi-part message in MIME format.
--------------Z0ZFYIlVESlli1mWptzW2EBu
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 3/5/26 19:42, Fujii Masao wrote:
> On Thu, Mar 5, 2026 at 5:15 PM David Steele <david@pgbackrest.org> wrote:
>>
>> On 3/5/26 12:03, Fujii Masao wrote:
>>> On Thu, Mar 5, 2026 at 1:21 PM David Steele <david@pgbackrest.org> wrote:
>>>> The prior standby is not running because of the invalid config. I
>>>> figured it was better to start clean but when I update the
>>>> recovery_target_timeline tests I was planning to use the same standby
>>>> for all the new tests.
>>>
>>> Alternatively, we can use $node_primary, since ALTER SYSTEM SET with
>>> invalid recovery_target_timeline or recovery_target_xid does not
>>> affect the primary.
>>
>> Well, as it turns out I was using the primary after all because I copied
>> your example and forgot to update the host. Seems weird to set these
>> GUCs on the primary but as long as we get the expected errors I don't
>> suppose it matters.
> 
> Thanks for updating the patch! I've pushed the patch.

Excellent, thank you!

Attached are the test changes for recovery_target_timeline. I can start 
a new thread and add it to the next CF if you like, but since it is just 
test changes maybe we can fast track it.

Regards,
-David
--------------Z0ZFYIlVESlli1mWptzW2EBu
Content-Type: text/plain; charset=UTF-8;
 name="recovery-target-timeline-v1.patch"
Content-Disposition: attachment; filename="recovery-target-timeline-v1.patch"
Content-Transfer-Encoding: base64

RnJvbSBjNzBkMDZkNDE1ODUyZTFkN2I5YmQ0NGQxN2U5ZWZhZjQ5MWRmYzFkIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBTdGVlbGUgPGRhdmlkQHBnbWFzdGVycy5u
ZXQ+CkRhdGU6IFRodSwgNSBNYXIgMjAyNiAxMzoyNzo1OCArMDAwMApTdWJqZWN0OiBJbXBy
b3ZlIHRlc3RzIGZvciByZWNvdmVyeV90YXJnZXRfdGltZWxpbmUgR1VDLgoKVXBkYXRlIHRo
ZSByZWNvdmVyeV90YXJnZXRfdGltZWxpbmUgdGVzdHMgdG8gbWF0Y2ggdGhlIHNpbXBsZXIg
Zm9ybWF0CnVzZWQgZm9yIHJlY292ZXJ5X3RhcmdldF94aWQgaW4gYmZmZDcxMzAuCi0tLQog
c3JjL3Rlc3QvcmVjb3ZlcnkvdC8wMDNfcmVjb3ZlcnlfdGFyZ2V0cy5wbCB8IDY4ICsrKysr
Ky0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKyksIDQ4
IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlY292ZXJ5L3QvMDAzX3Jl
Y292ZXJ5X3RhcmdldHMucGwgYi9zcmMvdGVzdC9yZWNvdmVyeS90LzAwM19yZWNvdmVyeV90
YXJnZXRzLnBsCmluZGV4IDRlMzZlM2EzZmI1Li4wNDdlYjEzMjkzYSAxMDA2NDQKLS0tIGEv
c3JjL3Rlc3QvcmVjb3ZlcnkvdC8wMDNfcmVjb3ZlcnlfdGFyZ2V0cy5wbAorKysgYi9zcmMv
dGVzdC9yZWNvdmVyeS90LzAwM19yZWNvdmVyeV90YXJnZXRzLnBsCkBAIC0xOTAsNTggKzE5
MCwzMCBAQCBsaWtlKAogCXFyL0ZBVEFMOiAuKiByZWNvdmVyeSBlbmRlZCBiZWZvcmUgY29u
ZmlndXJlZCByZWNvdmVyeSB0YXJnZXQgd2FzIHJlYWNoZWQvLAogCSdyZWNvdmVyeSBlbmQg
YmVmb3JlIHRhcmdldCByZWFjaGVkIGlzIGEgZmF0YWwgZXJyb3InKTsKIAotIyBJbnZhbGlk
IHRpbWVsaW5lIHRhcmdldAotJG5vZGVfc3RhbmRieSA9IFBvc3RncmVTUUw6OlRlc3Q6OkNs
dXN0ZXItPm5ldygnc3RhbmRieV85Jyk7Ci0kbm9kZV9zdGFuZGJ5LT5pbml0X2Zyb21fYmFj
a3VwKCRub2RlX3ByaW1hcnksICdteV9iYWNrdXAnLAotCWhhc19yZXN0b3JpbmcgPT4gMSk7
Ci0kbm9kZV9zdGFuZGJ5LT5hcHBlbmRfY29uZigncG9zdGdyZXNxbC5jb25mJywKLQkicmVj
b3ZlcnlfdGFyZ2V0X3RpbWVsaW5lID0gJ2JvZ3VzJyIpOwotCi0kcmVzID0gcnVuX2xvZygK
LQlbCi0JCSdwZ19jdGwnLAotCQknLS1wZ2RhdGEnID0+ICRub2RlX3N0YW5kYnktPmRhdGFf
ZGlyLAotCQknLS1sb2cnID0+ICRub2RlX3N0YW5kYnktPmxvZ2ZpbGUsCi0JCSdzdGFydCcs
Ci0JXSk7Ci1vayghJHJlcywgJ2ludmFsaWQgdGltZWxpbmUgdGFyZ2V0IChib2d1cyB2YWx1
ZSknKTsKLQotbXkgJGxvZ19zdGFydCA9ICRub2RlX3N0YW5kYnktPndhaXRfZm9yX2xvZygi
aXMgbm90IGEgdmFsaWQgbnVtYmVyIik7Ci0KLSMgVGltZWxpbmUgdGFyZ2V0IG91dCBvZiBt
aW4gcmFuZ2UKLSRub2RlX3N0YW5kYnktPmFwcGVuZF9jb25mKCdwb3N0Z3Jlc3FsLmNvbmYn
LAotCSJyZWNvdmVyeV90YXJnZXRfdGltZWxpbmUgPSAnMCciKTsKLQotJHJlcyA9IHJ1bl9s
b2coCi0JWwotCQkncGdfY3RsJywKLQkJJy0tcGdkYXRhJyA9PiAkbm9kZV9zdGFuZGJ5LT5k
YXRhX2RpciwKLQkJJy0tbG9nJyA9PiAkbm9kZV9zdGFuZGJ5LT5sb2dmaWxlLAotCQknc3Rh
cnQnLAotCV0pOwotb2soISRyZXMsICdpbnZhbGlkIHRpbWVsaW5lIHRhcmdldCAobG93ZXIg
Ym91bmQgY2hlY2spJyk7Ci0KLSRsb2dfc3RhcnQgPQotICAkbm9kZV9zdGFuZGJ5LT53YWl0
X2Zvcl9sb2coIm11c3QgYmUgYmV0d2VlbiAxIGFuZCA0Mjk0OTY3Mjk1IiwgJGxvZ19zdGFy
dCk7Ci0KLSMgVGltZWxpbmUgdGFyZ2V0IG91dCBvZiBtYXggcmFuZ2UKLSRub2RlX3N0YW5k
YnktPmFwcGVuZF9jb25mKCdwb3N0Z3Jlc3FsLmNvbmYnLAotCSJyZWNvdmVyeV90YXJnZXRf
dGltZWxpbmUgPSAnNDI5NDk2NzI5NiciKTsKKyMgSW52YWxpZCByZWNvdmVyeV90YXJnZXRf
dGltZWxpbmUgdGVzdHMKK215ICgkcmVzdWx0LCAkc3Rkb3V0LCAkc3RkZXJyKSA9ICRub2Rl
X3ByaW1hcnktPnBzcWwoJ3Bvc3RncmVzJywKKwkiQUxURVIgU1lTVEVNIFNFVCByZWNvdmVy
eV90YXJnZXRfdGltZWxpbmUgVE8gJ2JvZ3VzJyIpOworbGlrZSgKKwkkc3RkZXJyLAorCXFy
L2lzIG5vdCBhIHZhbGlkIG51bWJlci8sCisJImludmFsaWQgcmVjb3ZlcnlfdGFyZ2V0X3Rp
bWVsaW5lIChib2d1cyB2YWx1ZSkiKTsKIAotJHJlcyA9IHJ1bl9sb2coCi0JWwotCQkncGdf
Y3RsJywKLQkJJy0tcGdkYXRhJyA9PiAkbm9kZV9zdGFuZGJ5LT5kYXRhX2RpciwKLQkJJy0t
bG9nJyA9PiAkbm9kZV9zdGFuZGJ5LT5sb2dmaWxlLAotCQknc3RhcnQnLAotCV0pOwotb2so
ISRyZXMsICdpbnZhbGlkIHRpbWVsaW5lIHRhcmdldCAodXBwZXIgYm91bmQgY2hlY2spJyk7
CisoJHJlc3VsdCwgJHN0ZG91dCwgJHN0ZGVycikgPSAkbm9kZV9wcmltYXJ5LT5wc3FsKCdw
b3N0Z3JlcycsCisJIkFMVEVSIFNZU1RFTSBTRVQgcmVjb3ZlcnlfdGFyZ2V0X3RpbWVsaW5l
IFRPICcwJyIpOworbGlrZSgKKwkkc3RkZXJyLAorCXFyL211c3QgYmUgYmV0d2VlbiAxIGFu
ZCA0Mjk0OTY3Mjk1LywKKwkiaW52YWxpZCByZWNvdmVyeV90YXJnZXRfdGltZWxpbmUgKGxv
d2VyIGJvdW5kIGNoZWNrKSIpOwogCi0kbG9nX3N0YXJ0ID0KLSAgJG5vZGVfc3RhbmRieS0+
d2FpdF9mb3JfbG9nKCJtdXN0IGJlIGJldHdlZW4gMSBhbmQgNDI5NDk2NzI5NSIsICRsb2df
c3RhcnQpOworKCRyZXN1bHQsICRzdGRvdXQsICRzdGRlcnIpID0gJG5vZGVfcHJpbWFyeS0+
cHNxbCgncG9zdGdyZXMnLAorCSJBTFRFUiBTWVNURU0gU0VUIHJlY292ZXJ5X3RhcmdldF90
aW1lbGluZSBUTyAnNDI5NDk2NzI5NiciKTsKK2xpa2UoCisJJHN0ZGVyciwKKwlxci9tdXN0
IGJlIGJldHdlZW4gMSBhbmQgNDI5NDk2NzI5NS8sCisJImludmFsaWQgcmVjb3ZlcnlfdGFy
Z2V0X3RpbWVsaW5lICh1cHBlciBib3VuZCBjaGVjaykiKTsKIAogIyBJbnZhbGlkIHJlY292
ZXJ5X3RhcmdldF94aWQgdGVzdHMKLW15ICgkcmVzdWx0LCAkc3Rkb3V0LCAkc3RkZXJyKSA9
ICRub2RlX3ByaW1hcnktPnBzcWwoJ3Bvc3RncmVzJywKKygkcmVzdWx0LCAkc3Rkb3V0LCAk
c3RkZXJyKSA9ICRub2RlX3ByaW1hcnktPnBzcWwoJ3Bvc3RncmVzJywKIAkiQUxURVIgU1lT
VEVNIFNFVCByZWNvdmVyeV90YXJnZXRfeGlkIFRPICdib2d1cyciKTsKIGxpa2UoCiAJJHN0
ZGVyciwKLS0gCjIuMzQuMQoK

--------------Z0ZFYIlVESlli1mWptzW2EBu--