Feedback-ID: i1ff147bf:Fastmail
From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
Cc: Mahendra Singh Thalor <mahi6run@gmail.com>,  jian he
 <jian.universality@gmail.com>,  Srinath Reddy <srinath2133@gmail.com>,
  pgsql-hackers@lists.postgresql.org
Subject: Re: Non-text mode for pg_dumpall
References: <202503111705.xy7fddu36qae@alvherre.pgsql>
Date: Tue, 11 Mar 2025 17:52:17 +0000
In-Reply-To: <202503111705.xy7fddu36qae@alvherre.pgsql> (=?utf-8?Q?=22?=
 =?utf-8?Q?=C3=81lvaro?= Herrera"'s
	message of "Tue, 11 Mar 2025 18:05:59 +0100")
Message-ID: <8734fj1mlq.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/8734fj1mlq.fsf%40wibble.ilmari.org>
Precedence: bulk

Álvaro Herrera <alvherre@alvh.no-ip.org> writes:

> Hello,
>
> On 2025-Mar-11, Mahendra Singh Thalor wrote:
>
>> In map.dat file, I tried to fix this issue by adding number of characters
>> in dbname but as per code comments, as of now, we are not supporting \n\r
>> in dbnames so i removed handling.
>> I will do some more study to fix this issue.
>
> Yeah, I think this is saying that you should not consider the contents
> of map.dat as a shell string.  After all, you're not going to _execute_
> that file via the shell.
>
> Maybe for map.dat you need to escape such characters somehow, so that
> they don't appear as literal newlines/carriage returns.

I haven't looked at the code for this, but why are we inventing an
ad-hoc file format?  Why not use JSON, like we do for backup manifests?
Then storing arbitrary database names won't be a problem.

- ilmari