From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,  Andres Freund
 <andres@anarazel.de>,  Andrew Dunstan <andrew@dunslane.net>,  "Bossart,
 Nathan" <bossartn@amazon.com>,  Kyotaro Horiguchi
 <horikyota.ntt@gmail.com>,  "masao.fujii@oss.nttdata.com"
 <masao.fujii@oss.nttdata.com>,  "pgsql-hackers@lists.postgresql.org"
 <pgsql-hackers@lists.postgresql.org>,  "mengjuan.cmj@alibaba-inc.com"
 <mengjuan.cmj@alibaba-inc.com>,  "Jakub.Wartak@tomtom.com"
 <Jakub.Wartak@tomtom.com>,  Ryo Matsumura <matsumura.ryo@fujitsu.com>
Subject: Re: prevent immature WAL streaming
References: <202110132209.uyw4ubpc2ztc@alvherre.pgsql>
	<1669191.1635881881@sss.pgh.pa.us> <1372189.1636499287@sss.pgh.pa.us>
Date: Wed, 10 Nov 2021 13:31:06 +0000
In-Reply-To: <1372189.1636499287@sss.pgh.pa.us> (Tom Lane's message of "Tue,
	09 Nov 2021 18:08:07 -0500")
Message-ID: <8735o4qgrp.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Archived-At: 
 <https://www.postgresql.org/message-id/8735o4qgrp.fsf%40wibble.ilmari.org>
Precedence: bulk

Tom Lane <tgl@sss.pgh.pa.us> writes:

> Also, I think we want
>
> -ok($initfile != $endfile, "$initfile differs from $endfile");
> +ok($initfile ne $endfile, "$initfile differs from $endfile");
>
> The existing coding works as long as all characters of these
> WAL segment names happen to be decimal digits, but ...

Even better style (IMO) would be:

  isnt($initfile, $endfile, "WAL file name has changed");

Or some other more descriptive message of _why_ it should have changed.

- ilmari