From: Andreas Seltenreich <seltenreich@gmx.de>
To: Pavan Deolasee <pavan.deolasee@gmail.com>
Cc: Simon Riggs <simon@2ndquadrant.com>,
  Pavel Stehule <pavel.stehule@gmail.com>,
  Chapman Flack <chap@anastigmatix.net>,
  PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [HACKERS] MERGE SQL Statement for PG11
References: 
 <CANP8+jLdJoqjzkEdfqy_Rw43gUk08btunpJVV7Yiw=UqtOtePw@mail.gmail.com>
	<CANP8+jJgS_KoN6DDteb_9-fUzfnp7Ytm9O5VE83dGpWp1pszkg@mail.gmail.com>
	<CAH2-WznpEqdzL_sgWOHfmb9jz6612JLkhdN5YcdmdW3qX3g4Uw@mail.gmail.com>
	<CANP8+jKTuZ5NDCLkqXBm9kMeaT-jNxxhkMg+FOpLni=pwOQ=BA@mail.gmail.com>
	<CANP8+jKJee2Luip7tv4KrK8R_EP5PbOvDD+vfUpp9uBFmfK9yg@mail.gmail.com>
	<CANP8+jK8YRSCrg8m8XiRMmoy9DfvL=hUQ1SpS=+y=920evbTvg@mail.gmail.com>
	<CAFj8pRCUbOsyD5ny1UvoZciEbk3Q1YJj+gjEta=1X8dGb1cjSA@mail.gmail.com>
	<CANP8+jL86yJU0cx09DCWZVT=ZAo4JK1oqS_0s0t=WUN-FP9iaQ@mail.gmail.com>
	<CAFj8pRApqwbS9ZBf38=vg38rU90dotukx22xxV+Oe8fiCv=3Kg@mail.gmail.com>
	<CANP8+jKoE=AXPz+gMdxXgod7UO_C8OGwJ6aD+A4b5nfxLOzQrA@mail.gmail.com>
	<20180129154457.GC11613@momjian.us>
	<CANP8+jLDtMxYXJ95ffA3PYqAVfTkh3V42W9TYWAJH6PsAgOocg@mail.gmail.com>
	<495e24a5-d5bf-3ef2-ccdd-dd112c1c3a15@anastigmatix.net>
	<CANP8+j+icDb4=+zVUiRN60TAf9s9WT+6dOoWQqDu+B90xATRHA@mail.gmail.com>
	<CAFj8pRA7=C9yPJW_iG2Es-qBkZt-hSUFmF+cqZGoHU5SAPj_kw@mail.gmail.com>
	<CANP8+j+YDPtO9KsMX2ztXLxHjpmjef3ytfmhRfvK48db0o4btg@mail.gmail.com>
	<87k1vtdexn.fsf@ansel.ydns.eu>
	<CANP8+jLQ81X0dR2k2i6eOwg4226GGoTbRS6_e=6oDdmBRXwXYQ@mail.gmail.com>
	<87a7wpc5n3.fsf@ansel.ydns.eu>
	<CABOikdPtfpMoeWR827-fRy0Q2=3scGaRFDHY+HZ_cG0zJYV09w@mail.gmail.com>
Date: Sun, 18 Feb 2018 12:18:43 +0100
In-Reply-To: 
 <CABOikdPtfpMoeWR827-fRy0Q2=3scGaRFDHY+HZ_cG0zJYV09w@mail.gmail.com>
	(Pavan Deolasee's message of "Thu, 15 Feb 2018 16:49:46 +0530")
Message-ID: <87371yczqk.fsf@ansel.ydns.eu>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: bulk

--=-=-=
Content-Type: text/plain

Pavan Deolasee writes:

> Thanks for doing those tests. I've just sent v16a version of the patch and
> I think it fixes the issues reported so far. Can you please recheck? Please
> let me know if there are other issues detected by sqlsmith or otherwise.

I re-did the testing with merge_v16a applied to master at 7923118c16
with ad7dbee368a reverted because of conflicts.  I can confirm that the
previous testcases don't fail anymore, but sqlsmith readily triggers the
following assertion:

TRAP: FailedAssertion("!(mergeTargetRelation > 0)", File: "planner.c",
Line: 1496)

Testcase attached.

regards,
Andreas

--=-=-=
Content-Type: application/x-sql
Content-Disposition: attachment; filename=merge-v16a-trap-planner.c.sql
Content-Transfer-Encoding: base64

LS0gVFJBUDogRmFpbGVkQXNzZXJ0aW9uKCIhKG1lcmdlVGFyZ2V0UmVsYXRpb24gPiAwKSIsIEZp
bGU6ICJwbGFubmVyLmMiLCBMaW5lOiAxNDk2KQoKLS0gbWFzdGVyIGF0IDc5MjMxMThjMTYKLS0g
cmV2ZXJ0IGFkN2RiZWUzNjhhCi0tIGFwcGx5IG1lcmdlX3YxNmEucGF0Y2gKCkNSRUFURSBUQUJM
RSBoYXNoX2k0X2hlYXAgKAogICAgc2Vxbm8gaW50ZWdlciwKICAgIHJhbmRvbSBpbnRlZ2VyCik7
CkNSRUFURSBUQUJMRSBpZHhwYXJ0ICgKICAgIGEgaW50ZWdlcgopClBBUlRJVElPTiBCWSBSQU5H
RSAoYSk7CkNSRUFURSBUQUJMRSBpZHhwYXJ0MSBQQVJUSVRJT04gT0YgaWR4cGFydApGT1IgVkFM
VUVTIEZST00gKDApIFRPICgxMDApOwpDUkVBVEUgVEFCTEUgaWR4cGFydDIgUEFSVElUSU9OIE9G
IGlkeHBhcnQKRk9SIFZBTFVFUyBGUk9NICgxMDApIFRPICgxMDAwKQpQQVJUSVRJT04gQlkgUkFO
R0UgKGEpOwpDUkVBVEUgVEFCTEUgaWR4cGFydDIxIFBBUlRJVElPTiBPRiBpZHhwYXJ0MgpGT1Ig
VkFMVUVTIEZST00gKDEwMCkgVE8gKDIwMCk7CkNSRUFURSBUQUJMRSBpZHhwYXJ0MjIgUEFSVElU
SU9OIE9GIGlkeHBhcnQyCkZPUiBWQUxVRVMgRlJPTSAoMjAwKSBUTyAoMzAwKTsKQ1JFQVRFIElO
REVYIGhhc2hfaTRfaW5kZXggT04gaGFzaF9pNF9oZWFwIFVTSU5HIGhhc2ggKHJhbmRvbSk7CkNS
RUFURSBJTkRFWCBpZHhwYXJ0MV9hX2lkeCBPTiBpZHhwYXJ0MSBVU0lORyBidHJlZSAoYSk7CkNS
RUFURSBJTkRFWCBpZHhwYXJ0MjJfYV9pZHggT04gaWR4cGFydDIyIFVTSU5HIGJ0cmVlIChhKTsK
Q1JFQVRFIElOREVYIGlkeHBhcnQyX2FfaWR4IE9OIE9OTFkgaWR4cGFydDIgVVNJTkcgYnRyZWUg
KGEpOwpDUkVBVEUgSU5ERVggaWR4cGFydF9hX2lkeCBPTiBPTkxZIGlkeHBhcnQgVVNJTkcgYnRy
ZWUgKGEpOwpBTFRFUiBJTkRFWCBwdWJsaWMuaWR4cGFydF9hX2lkeCBBVFRBQ0ggUEFSVElUSU9O
IHB1YmxpYy5pZHhwYXJ0MV9hX2lkeDsKQUxURVIgSU5ERVggcHVibGljLmlkeHBhcnQyX2FfaWR4
IEFUVEFDSCBQQVJUSVRJT04gcHVibGljLmlkeHBhcnQyMl9hX2lkeDsKQUxURVIgSU5ERVggcHVi
bGljLmlkeHBhcnRfYV9pZHggQVRUQUNIIFBBUlRJVElPTiBwdWJsaWMuaWR4cGFydDJfYV9pZHg7
CmJlZ2luO01FUkdFIElOVE8gcHVibGljLmlkeHBhcnQgYXMgdGFyZ2V0XzAKVVNJTkcgcHVibGlj
Lmhhc2hfaTRfaGVhcCBhcyByZWZfMApPTiB0YXJnZXRfMC5hID0gcmVmXzAuc2Vxbm8gCldIRU4g
TUFUQ0hFRCAKICBBTkQgdHJ1ZQogICBUSEVOIERFTEVURQo7cm9sbGJhY2s7Cg==
--=-=-=--