Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1wL1UR-001TfO-1x
	for pgsql-hackers@arkaria.postgresql.org;
	Thu, 07 May 2026 16:22:19 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1wL1UQ-0057P1-1N
	for pgsql-hackers@arkaria.postgresql.org;
	Thu, 07 May 2026 16:22:18 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1wL1UQ-0057Ot-0S
	for pgsql-hackers@lists.postgresql.org;
	Thu, 07 May 2026 16:22:18 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1wL1UN-00000000fVy-3UpQ
	for pgsql-hackers@postgresql.org;
	Thu, 07 May 2026 16:22:17 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.18.1/8.18.1) with ESMTP id 647GM4EH873910;
	Thu, 7 May 2026 12:22:04 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <johncnaylorls@gmail.com>
cc: Jakob Egger <jakob@eggerapps.at>,
        pgsql-hackers <pgsql-hackers@postgresql.org>,
        Tobias Bussmann <t.bussmann@gmx.net>
Subject: Re: Broken build on macOS (Universal / Intel): cpuid instruction not
 available
In-reply-to: <871806.1778168884@sss.pgh.pa.us>
References: <223EA201-A0E8-4A13-B220-EB903E8DF817@eggerapps.at>
 <871806.1778168884@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Thu, 07 May 2026 11:48:04 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <873908.1778170924.1@sss.pgh.pa.us>
Date: Thu, 07 May 2026 12:22:04 -0400
Message-ID: <873909.1778170924@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/873909.1778170924%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> ... The code in HEAD doesn't have
> that guard, and is essentially assuming that every x86 platform
> wil provide HAVE__GET_CPUID or HAVE__CPUID.

Independently of whether macOS multi-arch is something we consider
supportable, I think the aforesaid assumption is a bad idea.
Can't we make pg_cpuid() return zeroes if it doesn't know how to
get the info, analogously to what pg_cpuid_subleaf() does?

			regards, tom lane