Feedback-ID: i1ff147bf:Fastmail
From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,  Melanie Plageman
 <melanieplageman@gmail.com>,  Peter Eisentraut <peter@eisentraut.org>,
  Andres Freund <andres@anarazel.de>,  =?utf-8?Q?=C3=81lvaro?= Herrera
 <alvherre@kurilemu.de>,  Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: remove bits* types
References: <absbX33E4eaA0Ity@nathan>
	<a3b5edc3-c0f5-42ae-b463-17018ee03dcb@eisentraut.org>
	<acV5NYm4XBzIE50N@nathan>
	<CAAKRu_ZucXL3mLc0f-t_7giiChN9Zad2EAr9SoAqFFc95vFaOg@mail.gmail.com>
	<acqsERCb1t8OCZpG@nathan> <2493698.1774890452@sss.pgh.pa.us>
	<acqu7Z40kvJ4t8O8@nathan>
Date: Mon, 30 Mar 2026 18:36:48 +0100
In-Reply-To: <acqu7Z40kvJ4t8O8@nathan> (Nathan Bossart's message of "Mon, 30
	Mar 2026 12:12:13 -0500")
Message-ID: <874ilx43tb.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/874ilx43tb.fsf%40wibble.ilmari.org>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:

> On Mon, Mar 30, 2026 at 01:07:32PM -0400, Tom Lane wrote:
>> Nathan Bossart <nathandbossart@gmail.com> writes:
>>> With Melanie's note, there are at least 4 votes in favor of this patch
>>> (Andres, me, Peter, and Melanie).  AFAICT Michael is +/-0, Álvaro and Tom
>>> are -1 (or somewhere in the vicinity), and Robert seems ambivalent.  Hm...
>> 
>> To clarify, what I said was we should either remove them or use them
>> more consistently.  I don't think 1bd6f22f4 moved the needle very
>> far towards option 2, so I'm totally fine with option 1.  Put me
>> down as +0.5.
>
> Thanks for clarifying.  Given that update and Álvaro's note upthread [0],
> I'd argue we're in rough consensus territory and can move forward with the
> patch.  If no objections materialize shortly, I'll do so.

To avoid breaking extensions, we could leave the typedefs in place with
an #ifndef guard on some symbol that's only defined when building
postgres itself, but not when building extensions (or vice versa with an
#ifdef instead).

This is used a lot in Perl for things we don't want to use in core any
more, but we don't want to break CPAN modules still using.

- ilmari