Feedback-ID: i1ff147bf:Fastmail
From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: px shi <spxlyy123@gmail.com>,  pgsql-hackers@postgresql.org
Subject: Re: CREATE MATERIALIZED VIEW
References: <CAAccyY+Wg1Z-9tNfSwLmuZVgGOwqU5u1OP-RWcoAr2UZGuvN_w@mail.gmail.com>
	<87cyn1eft4.fsf@wibble.ilmari.org> <87a5i5ef7e.fsf@wibble.ilmari.org>
	<ZqJjZscmd5TrTR36@nathan> <877cd9edcx.fsf@wibble.ilmari.org>
	<ZqJnCV1pH99TUF7v@nathan>
Date: Thu, 25 Jul 2024 16:10:37 +0100
In-Reply-To: <ZqJnCV1pH99TUF7v@nathan> (Nathan Bossart's message of "Thu, 25
	Jul 2024 09:54:01 -0500")
Message-ID: <874j8deccy.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/874j8deccy.fsf%40wibble.ilmari.org>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:

> On Thu, Jul 25, 2024 at 03:49:02PM +0100, Dagfinn Ilmari Mannsåker wrote:
>> Nathan Bossart <nathandbossart@gmail.com> writes:
>>> However, since it looks like the feature was never actually supported in a
>>> release, and the revert has been in place for over a decade, I think it'd
>>> be reasonable to remove the tab completion now.  It looks like the folks on
>>> the 2021 thread felt similarly.
>> 
>> Keeping it in the grammar makes sense for the more specific error
>> message, but I don't think the tab completion should be suggesting bogus
>> things, regardless of whether it's the grammar or the parse analysis
>> that rejects it.
>
> Would you mind creating a commitfest entry for this one?  I'll plan on
> committing this early next week unless any objections materialize.

Done: https://commitfest.postgresql.org/49/5139/

I've taken the liberty of setting you as the committer, and the target
version to 17 even though it turns out to be an older bug, since it's
arguably a follow-on fix to the incomplete fix in c951e9042dd1.

- ilmari