Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q3wai-0003Wq-Ls for pgsql-hackers@arkaria.postgresql.org; Tue, 30 May 2023 10:28:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q3wag-0000vp-Lx for pgsql-hackers@arkaria.postgresql.org; Tue, 30 May 2023 10:28:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q3waf-0000vg-7n for pgsql-hackers@lists.postgresql.org; Tue, 30 May 2023 10:28:34 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q3waa-00333c-Mm for pgsql-hackers@postgresql.org; Tue, 30 May 2023 10:28:32 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 59D005C0046; Tue, 30 May 2023 06:28:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 30 May 2023 06:28:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilmari.org; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1685442507; x=1685528907; bh=KH6R25Sn4ugP674kVWuYSJHqk4/ZTe7zCKa 5H+0HsgQ=; b=uHC18UyxWvDJoUrr66udXRDxhkn1Xig2pw2DGrOeVUox8HS6OK/ SWBYISU6qkKUCX+pjhHpwESvR0hYKJRVtp1nicJxFmUoV01YYMKZWzjgUJyk8YKt ymfVTcB3HVs8C+eC2qK3Mji8oAs7ZeNAyfcj3/BtgCkX2HS/PG4BG3y/4pPGMTsD EVFQOmo/auxwhOezofcphvvCK/sPuKy9RsXe1TB7xBwg1WU+7jDdMpW+ufaPbR9l yFrPkmMsMgKHIjxKllZMILzE6T09s5xIoJk/uuidI3Vck3m5gpMl5Ud5jOH07SW7 JVDfeOB2hQyaGVd1YyLNBHqHKSM0y+9QQLA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1685442507; x=1685528907; bh=KH6R25Sn4ugP674kVWuYSJHqk4/ZTe7zCKa 5H+0HsgQ=; b=SeKbAvDJybk3mk1iGpc1iszajWxaRMAiNeLvz8DIYeVVJkbysSe DXunwOzCi3V/XuL2Vb9/SHhiu4GuwL5ZsonL3l6xpY3Db4r86pvewcUnHZjXDNBD X+NWtNKmW1ZjCTY/I6WuO02GtG0o2566D4dwNxwJD6P2BXA1EJSZFlhTtaRrG6cS JFEGt0AAFmJhITNhkaqio0JGgHO/uBtUYd9fhTDwCBGwtipIzidUkuL7QUp0sbAV aIkLWp/93tdfVpIPhzJ/ItsfhrdGJTBMPa6VsVfp9HcJr7aiZT0jrnS9jPu8RVdb dSsdtt8Sx258ryzN5iHiqCHL+WswzVOytmg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeekjedgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufhffjgfkfgggtgfgsehtkeertddtreejnecuhfhrohhmpeffrghg fhhinhhnucfklhhmrghrihcuofgrnhhnshonkhgvrhcuoehilhhmrghrihesihhlmhgrrh hirdhorhhgqeenucggtffrrghtthgvrhhnpedtjeevueejgeejvdffuedujeethffhhefg tdfhieejffekveekgfdtffejhfdtieenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehilhhmrghrihesihhlmhgrrhhirdhorhhg X-ME-Proxy: Feedback-ID: i1ff147bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 30 May 2023 06:28:26 -0400 (EDT) From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= To: Bruce Momjian Cc: PostgreSQL-development Subject: Re: PG 16 draft release notes ready References: <878rdctb7o.fsf@wibble.ilmari.org> Date: Tue, 30 May 2023 11:28:24 +0100 In-Reply-To: (Bruce Momjian's message of "Tue, 30 May 2023 06:03:19 -0400") Message-ID: <874jnut8on.fsf@wibble.ilmari.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Bruce Momjian writes: > On Sat, May 27, 2023 at 09:34:37PM -0400, Bruce Momjian wrote: >> > > This is controlled by auto_explain.log_parameter_max_length, and by >> > > default query parameters will be logged with no length >> > > restriction. SHOULD THIS BE MORE CLEARLY IDENTIFIED AS CONTROLLING THE >> > > EXECUTION OF PREPARED STATEMENTS? >> > >> > This is wrong, the logging applies to all query parameters, not just for >> > prepared statements (and has nothing to do with controlling the >> > execution thereof). That was just the only way to test it when it was >> > written, because psql's \bind command exist yet then. >> >> I see your point. How is this? >> >> Allow auto_explain to log query parameters used by parameterized >> statements (Dagfinn Ilmari Mannsåker) >> >> This affects queries using server-side PRAPARE/EXECUTE >> and client-side parse/bind. Logging is controlled by >> auto_explain.log_parameter_max_length; by default query >> parameters will be logged with no length restriction. > > Done, attached patch applied. That works for me. Thanks! - ilmari