Feedback-ID: i1ff147bf:Fastmail
From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>,  Peter Smith
 <smithpb2250@gmail.com>,  Andrew Dunstan <andrew@dunslane.net>,
  PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_createsubscriber TAP test wrapping makes command options
 hard to read.
References: <87jzc46d8u.fsf@wibble.ilmari.org>
	<5f41d6c6-1cbb-494d-a5c4-3c449fc4e9ad@dunslane.net>
	<105f432a-6b0b-42d4-9061-65d263279be7@app.fastmail.com>
	<CAHut+PuD0aQfjAN0q_7FpdNdSEdrhONpTsb0tQi5ZEtZHj6bKg@mail.gmail.com>
	<87ldv542fk.fsf@wibble.ilmari.org>
	<CAHut+PvKrQXY7kM8ct=HC9xYPC6yhdJWnvCgijtgxmO-mus8uQ@mail.gmail.com>
	<Z49PYgXnbyU6IiEe@paquier.xyz> <87frlc45gg.fsf@wibble.ilmari.org>
	<Z5CHN6WajoZP6Rqz@paquier.xyz> <878qr146ra.fsf@wibble.ilmari.org>
	<Z5MxuDQBr_S8YNwW@paquier.xyz> <379085.1737734611@sss.pgh.pa.us>
Date: Fri, 24 Jan 2025 18:59:42 +0000
In-Reply-To: <379085.1737734611@sss.pgh.pa.us> (Tom Lane's message of "Fri, 24
	Jan 2025 11:03:31 -0500")
Message-ID: <875xm43un5.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Archived-At: <https://www.postgresql.org/message-id/875xm43un5.fsf%40wibble.ilmari.org>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

Tom Lane <tgl@sss.pgh.pa.us> writes:

> Michael Paquier <michael@paquier.xyz> writes:
>> On Thu, Jan 23, 2025 at 08:25:45PM +0000, Dagfinn Ilmari Mannsåker wrote:
>>> Here's a patch for that.
>
>> Thanks.  I had a bit of time today and applied it.
>
> BF member drongo doesn't like the new test for amcheck.
> Looks like it has to do with SSPI authentication producing
> a different error than expected:

Ah yes, I always forget about that quirk on Windows.

> stderr:
> #   Failed test 'checking with a non-existent user stderr /(?^:role "no_such_user" does not exist)/'
> #   at C:/prog/bf/root/HEAD/pgsql/src/bin/pg_amcheck/t/002_nonesuch.pl line 86.
> # 'pg_amcheck: error: connection to server at "127.0.0.1", port 19928
> failed: FATAL: SSPI authentication failed for user "no_such_user"
> # '
> #     doesn't match '(?^:role "no_such_user" does not exist)'
> # Looks like you failed 1 test of 107.
>
> You might be able to work around this with auth_extra,
> a la 1e3f461e8 and other past fixes.

Here's a (blind, but at least doesn't break on Linux) patch for that.

- ilmari


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
 filename=0001-Fix-Windows-pg_amcheck-test-failure.patch

From eb168096c3e88cbd849907f7b6398d87a7844544 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dagfinn=20Ilmari=20Manns=C3=A5ker?= <ilmari@ilmari.org>
Date: Fri, 24 Jan 2025 18:50:05 +0000
Subject: [PATCH] Fix Windows pg_amcheck test failure

For SSPI auth extra users need to be explicitly allowed, or we get
"SSPI authentication failed" instead of the expected "role does not
exist" error.
---
 src/bin/pg_amcheck/t/002_nonesuch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/pg_amcheck/t/002_nonesuch.pl b/src/bin/pg_amcheck/t/002_nonesuch.pl
index 2697f1c1b1a..f23368abeab 100644
--- a/src/bin/pg_amcheck/t/002_nonesuch.pl
+++ b/src/bin/pg_amcheck/t/002_nonesuch.pl
@@ -11,7 +11,7 @@
 # Test set-up
 my ($node, $port);
 $node = PostgreSQL::Test::Cluster->new('test');
-$node->init;
+$node->init(auth_extra => [ '--create-role' => 'no_such_user' ]);
 $node->start;
 $port = $node->port;
 
-- 
2.39.5


--=-=-=--