Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyGH7-0006Fa-4u for pgsql-hackers@arkaria.postgresql.org; Mon, 06 Jun 2022 17:12:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nyGH5-0007mn-I4 for pgsql-hackers@arkaria.postgresql.org; Mon, 06 Jun 2022 17:12:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyGH3-0007me-W7 for pgsql-hackers@lists.postgresql.org; Mon, 06 Jun 2022 17:12:19 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyGGv-0000XF-Gb for pgsql-hackers@lists.postgresql.org; Mon, 06 Jun 2022 17:12:17 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 2C193320095F for ; Mon, 6 Jun 2022 13:12:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 06 Jun 2022 13:12:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilmari.org; h=cc :content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1654535524; x= 1654621924; bh=VhdIR1o5TLlUAsGTR1wfBOypLC+3MLVNj79K61+AuFE=; b=0 Q+va67gxxjm/LXbWCoMPyk6/OJhrsM6fHH7PchhtaN2Aq4rvrazOdqWaMjUak035 0p+fhbDc8aWPdgpU5jr84SJsgeFvd9Gp8V2/gY7UiPFYkcbM2t0G4A6uOu2rlnG6 idiG4kQnUCS0EfK3I7ngSWf10rPY/n8JQ639CI5ewUngoCFT4Y+GrOnGulbtJaZ9 IeCXPQu6jh0icto+hi9gZYip244AkH7SFV1DyVA0E/UAc3djt7+hZdl0yjBnDWH5 +wt2kWdTdwGGljBcsi1wvIEidD5+SvIVoXwY6Dcm5RITeABBrzVLTrjHyC70pMpC CMpbnNPY1wDge4dwDxoiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1654535524; x=1654621924; bh=V hdIR1o5TLlUAsGTR1wfBOypLC+3MLVNj79K61+AuFE=; b=kinz7Ia8/IiLKpHVy IWQ+WAjHe7yoeFwJ2OhE8zrCgP8hKOTEjcr9zvnyCUZFidfjBUDLO38AqFhqPt05 0swLxvJs4taroKZC6wAZdSUghTjXM3wM8EpJFQurXI71WM+auSFBjWrzCkl/9vvy iZWnWS8HKZGdHM3mK8+PLhRfQhcnVrEvvGxxUCEPMSa36aqEd7NFh5gbCnSTD+3w pI4LGByUeoWB+ExfKali9/QZsaXbr43PPXXTDgmxMp+05619xFr66wOxfEIkWfWA C0Hhf4kRZu5tABxSiLYGGjRbK3JH1yfvFNWsObTweDUBq2mJw7U1kPUf7iqqAB+m xIrOA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedruddtfedgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufhffjgfkfgggtgfgsehtke ertddtreejnecuhfhrohhmpeffrghgfhhinhhnpgfklhhmrghrihgpofgrnhhnshonkhgv rhcuoehilhhmrghrihesihhlmhgrrhhirdhorhhgqeenucggtffrrghtthgvrhhnpeefvd efiefgudfgtdfhffeludduveffjedvfeekuedvieeivdejtdeujeeffedugeenucffohhm rghinhepphhoshhtghhrvghsqhhlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepihhlmhgrrhhisehilhhmrghrihdrohhrgh X-ME-Proxy: Feedback-ID: i1ff147bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Mon, 6 Jun 2022 13:12:03 -0400 (EDT) From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= To: pgsql-hackers@lists.postgresql.org Subject: Re: Logging query parmeters in auto_explain References: <87ee09mohb.fsf@wibble.ilmari.org> Date: Mon, 06 Jun 2022 18:12:02 +0100 In-Reply-To: <87ee09mohb.fsf@wibble.ilmari.org> ("Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker=22's?= message of "Tue, 31 May 2022 21:33:20 +0100") Message-ID: <875yldn2cd.fsf@wibble.ilmari.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Dagfinn Ilmari Mannsåker writes: > Hi hackers, > > Inspired by a question on IRC, I noticed that while the core statement > logging system gained the option to log statement parameters in PG 13, > auto_explain was left out. > > Here's a patch that adds a corresponding > auto_explain.log_parameter_max_length config setting, which controls the > "Query Parameters" node in the logged plan. Just like in core, the > default is -1, which logs the parameters in full, and 0 disables > parameter logging, while any other value truncates each parameter to > that many bytes. I've added added it to the upcoming commitfest: https://commitfest.postgresql.org/38/3660/ - ilmari