Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1flI65-0001iX-Gg for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Aug 2018 18:13:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1flI63-0008Of-QE for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Aug 2018 18:13:11 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1flI63-0008OX-FD for pgsql-hackers@lists.postgresql.org; Thu, 02 Aug 2018 18:13:11 +0000 Received: from lungold.riddles.org.uk ([82.68.208.19]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1flI60-0007R4-GI for pgsql-hackers@postgresql.org; Thu, 02 Aug 2018 18:13:10 +0000 Received: from [192.168.127.1] (port=46497 helo=caithnard.riddles.org.uk) by lungold.riddles.org.uk with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.88 (FreeBSD)) (envelope-from ) id 1flI5x-0004YN-Pe; Thu, 02 Aug 2018 18:13:05 +0000 Received: from [127.0.0.1] (port=37185 helo=caithnard.riddles.org.uk) by caithnard.riddles.org.uk with esmtp (Exim 4.89 (FreeBSD)) (envelope-from ) id 1flI5x-000AAy-4a; Thu, 02 Aug 2018 18:13:05 +0000 From: Andrew Gierth To: Tom Lane Cc: Robert Haas , Peter Geoghegan , Andres Freund , PostgreSQL Hackers Subject: Re: Should contrib modules install .h files? In-Reply-To: <87a7q4adnk.fsf@news-spur.riddles.org.uk> (Andrew Gierth's message of "Thu, 02 Aug 2018 18:56:22 +0100") Message-ID: <87600sabb2.fsf@news-spur.riddles.org.uk> References: <87h8lhoevw.fsf@news-spur.riddles.org.uk> <63819.1530544945@sss.pgh.pa.us> <878t6to8j9.fsf@news-spur.riddles.org.uk> <874lhho071.fsf@news-spur.riddles.org.uk> <67427.1530738056@sss.pgh.pa.us> <87po02m0bh.fsf@news-spur.riddles.org.uk> <87in5tnafh.fsf@news-spur.riddles.org.uk> <87efghn7js.fsf@news-spur.riddles.org.uk> <87a7r5n4n2.fsf@news-spur.riddles.org.uk> <87o9enb4h7.fsf@news-spur.riddles.org.uk> <20180731201700.zfscje7clxiljvjl@alap3.anarazel.de> <11978.1533073999@sss.pgh.pa.us> <1836.1533221640@sss.pgh.pa.us> <87lg9oaghh.fsf@news-spur.riddles.org.uk> <25706.1533229991@sss.pgh.pa.us> <87a7q4adnk.fsf@news-spur.riddles.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (berkeley-unix) Date: Thu, 02 Aug 2018 19:13:05 +0100 MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk >>>>> "Andrew" == Andrew Gierth writes: Tom> There's also a question of whether we need to change anything in Tom> contrib/ so that it plays by whatever rules we set. There's an Tom> expectation that contrib modules should be buildable with PGXS, Tom> so they need to follow the rules. Andrew> ... that at least all of the *_plperl transform modules in Andrew> contrib/ fail to build with USE_PGXS already (i.e. for as long Andrew> as they have ever existed), because they rely on Andrew> plperl_helpers.h which is never installed anywhere, and trying Andrew> to get it via $(top_srcdir) obviously can't work in PGXS. Andrew> Haven't tried the python ones yet. And none of the plpython transforms can even parse their makefiles with USE_PGXS, let alone build, because they have an "include" directive pointing into src/pl/plpython. -- Andrew (irc:RhodiumToad)