Message-ID: <877b2c60-6681-4471-ba72-86153f0b9286@yandex.ru>
Date: Mon, 16 Mar 2026 15:11:06 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Vacuum statistics
To: Andrei Lepikhov <lepihov@gmail.com>, Andrey Borodin <x4mmm@yandex-team.ru>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
 Alexander Korotkov <aekorotkov@gmail.com>,
 Amit Kapila <amit.kapila16@gmail.com>, Jim Nasby <jnasby@upgrade.com>,
 Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
 Kirill Reshke <reshkekirill@gmail.com>, Andrei Zubkov <zubkov@moonset.ru>,
 Masahiko Sawada <sawada.mshk@gmail.com>,
 Melanie Plageman <melanieplageman@gmail.com>,
 jian he <jian.universality@gmail.com>, Sami Imseih <samimseih@gmail.com>,
 vignesh C <vignesh21@gmail.com>,
 Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
References: <86f76aa5-1ab5-4e2e-9b15-405051852a2a@postgrespro.ru>
 <CAPpHfdtQd29O15Cmp1qeqTCerQF0Y+BGh63qtX3RkA7k=0TZ1Q@mail.gmail.com>
 <18169b68-5b10-40fd-9657-be04f2bd0161@postgrespro.ru>
 <cb205605-d24c-41a3-9205-fe59e13af9ed@postgrespro.ru>
 <f5097647-89f9-4288-9010-9f690778dd53@postgrespro.ru>
 <c43ef413-f65b-46a5-b8a1-28949daaa889@tantorlabs.com>
 <612819ad-beca-41fb-bb7f-d5a7c11f0045@yandex.ru>
 <de4bdbff-a86c-4830-82b1-0c14af2b597d@postgrespro.ru>
 <277ce149-4333-463d-bad6-ccd785606c7f@yandex.ru>
 <3f9c57bc-dc1f-4ad8-a2e1-5be15ac79264@yandex.ru>
 <77f1b8bc-b365-4e88-b87b-ced37fabbbf0@yandex.ru>
 <a6450303-30fe-4d6e-b31a-055dccf09a2b@gmail.com>
 <f4d067c7-8e3e-451a-b13e-28a08b3b871f@gmail.com>
 <7a74d6af-85e2-4b48-9133-61309a965954@yandex.ru>
 <1885f257-46cc-4b90-8d90-41833eb62ea9@gmail.com>
 <0e84acdc-ba65-44fa-be1f-4d6a86bca2ac@yandex.ru>
 <8bd78e04-6efa-4fcf-b157-8ac3b92375c8@yandex.ru>
 <10BE6E39-94D2-4909-ACB8-24E1FA6580EE@yandex-team.ru>
 <cd323289-5ac7-42e4-9fec-b87cf8fdb40a@gmail.com>
Content-Language: en-US
From: Alena Rybakina <lena.ribackina@yandex.ru>
In-Reply-To: <cd323289-5ac7-42e4-9fec-b87cf8fdb40a@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/877b2c60-6681-4471-ba72-86153f0b9286%40yandex.ru>
Precedence: bulk

On 16.03.2026 11:45, Andrei Lepikhov wrote:

> On 15/3/26 18:18, Andrey Borodin wrote:
>>> On 13 Mar 2026, at 18:04, Alena Rybakina <lena.ribackina@yandex.ru> 
>>> wrote:
>>
>> I've decided to take a look into v31.
>>
>> Overall idea of tracking VM dynamics seems good to me.
>>
>> But the column naming for rev_all_visible_pages and rev_all_frozen_pages
>> seems strange to me. I've skimmed the thread but could not figure out 
>> what
>> "rev_" stands for. Revisions? Revolutions? Reviews?
>
> I suppose 'revert' is the exact term here. Someone decided to set the 
> flag, and we reverted his decision. Does this make sense to you? 
> Anyway, I always leave it in the natives' (and committers') hands.

I think renaming them to 'cleared' helps avoid the confusion.

I have adopted the names proposed by A. Zubkov in v34.

>> Some nits about the code.
>
> I doubt if we need a test for these parameters - they reflect the 
> physical structure of the storage and might be unstable. But anyway, 
> it should be better to live in isolation tests, as similar statistics.
>
I moved the tests there. Regression tests are unfortunately not an 
option because the statistics are not stable.

If the isolation test turns out to be unstable again, I'll move them 
back to the TAP tests as I initially implemented,
following A. Borodin's suggestion.

See the version in the 
https://www.postgresql.org/message-id/767d28c9-2ae8-43df-9f2e-3e8785075115%40yandex.ru

-- 
-----------
Best regards,
Alena Rybakina