Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1trzKi-00CyEs-5n for pgsql-hackers@arkaria.postgresql.org; Tue, 11 Mar 2025 13:07:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1trzKg-00G2ZO-UP for pgsql-hackers@arkaria.postgresql.org; Tue, 11 Mar 2025 13:07:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1trzKg-00G2Z8-56 for pgsql-hackers@lists.postgresql.org; Tue, 11 Mar 2025 13:07:42 +0000 Received: from fhigh-a4-smtp.messagingengine.com ([103.168.172.155]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1trzKd-002ENx-2X for pgsql-hackers@lists.postgresql.org; Tue, 11 Mar 2025 13:07:41 +0000 Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfhigh.phl.internal (Postfix) with ESMTP id 942F6114018A; Tue, 11 Mar 2025 09:07:38 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Tue, 11 Mar 2025 09:07:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilmari.org; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1741698458; x=1741784858; bh=elGfcnm5gT rL/rTmekOPQdSyO2WhjnDcEwh3a7jGa1Q=; b=M8qUQgUrWqLCMiaUuW1vfErN+1 FNrwdysH/quz7W/UzthObgsUQOs+H5ThzldeWQ3DYmtcVcoAEUICrXRnVSefr++T x91zpUIsw82VW3c5QhwQL/epwEU9DTCCRyo0C73ftq+DGPtiz4mw50favqU/DqAV seLyspYbkyXPXTFj7JcywvjkYLjMpgJje6RUyfBd25seBs49UrCx/BoG7pzbj+/P Uar3pUhbGhwgVFm7cFN7wpooW9t9dpMzJJkwOjBx3YO0XUzraqNfwHId1QRBjQcA +c/6zGF24unNAAE7xR/7WADifSfFAzhkBhAarshVaoE2y0kfQgQ9Ml8H+aBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1741698458; x=1741784858; bh=elGfcnm5gTrL/rTmekOPQdSyO2WhjnDcEwh 3a7jGa1Q=; b=ZrMG2NH8BSJXVVfGi+y3MELg2fCc+9KZidVqB0eIuGab9oZziz/ YNnHVwZ/tS1mDDH4bZXiObn1gDwJyYG2K+yAAIl/c2RPYMaRvBtSJwRh86XwgbhW g17XNZgpoFzZn8JQatBFuAax31lzvHtILZj9PO7j0+vKq0iAg76CUVlWM48FSNx6 ec50XJw8QqMcF2tBLijTh+04Naig2GMZJRwTv0dwj+pZYYyfT1ZABi9iFB1ymcua Xg4+nJQyXlcjzmB84Ho+1ngERq8wwCnl/5+enc0oSf8FX42cxqt59dOmoBz/5t9M Z79R4VlyI4muB3G/EB7qcn5yFG2zeu/+u6Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduvddvfeduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffvvefufhffjgfkfgggtgesthdtredttder jeenucfhrhhomhepffgrghhfihhnnhcukfhlmhgrrhhiucforghnnhhsnohkvghruceoih hlmhgrrhhisehilhhmrghrihdrohhrgheqnecuggftrfgrthhtvghrnhepkeeljeeufefh ffekhfektdefleeuvdeiiefhheeffeefgeegudffudehjeejiefgnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihhlmhgrrhhisehilhhmrghr ihdrohhrghdpnhgspghrtghpthhtohephedpmhhouggvpehsmhhtphhouhhtpdhrtghpth htohepphhgshhqlhdqhhgrtghkvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdho rhhgpdhrtghpthhtohepmhgsrghntghksehgmhigrdhnvghtpdhrtghpthhtohepmhhitg hhrggvlhesphgrqhhuihgvrhdrgiihiidprhgtphhtthhopegurghnihgvlheshigvshhq lhdrshgvpdhrtghpthhtohepthhomhgrshesvhhonhgurhgrrdhmvg X-ME-Proxy: Feedback-ID: i1ff147bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 Mar 2025 09:07:36 -0400 (EDT) From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= To: Tomas Vondra Cc: Daniel Gustafsson , Michael Paquier , Michael Banck , PostgreSQL Hackers Subject: Re: Changing the state of data checksums in a running cluster References: <8B317721-1CB7-4F82-B4DA-6B15AB1725D1@yesql.se> <642b8eeb-06ef-4aed-97a8-5297d9f67142@vondra.me> <2bf72a05-a2ce-4470-ba5a-adff3f087b55@vondra.me> <18750566-7D92-4FFE-9AAE-909AF99D3C33@yesql.se> <817F3431-4A4F-4070-B850-196199CD029F@yesql.se> <25edd1d1-e693-4386-bbcc-765ea1820044@vondra.me> <49f6df22-7a40-4ce1-a651-111ac033b2bb@vondra.me> <82E20987-0A25-489C-935B-B54ABF165542@yesql.se> <9a2f67a1-faba-423d-bd3d-08a01ca35494@vondra.me> Date: Tue, 11 Mar 2025 13:07:35 +0000 In-Reply-To: <9a2f67a1-faba-423d-bd3d-08a01ca35494@vondra.me> (Tomas Vondra's message of "Mon, 10 Mar 2025 16:01:35 +0100") Message-ID: <877c4v1zs8.fsf@wibble.ilmari.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk As the resident perl style pedant, I'd just like to complain about the below: Tomas Vondra writes: > diff --git a/src/test/perl/PostgreSQL/Test/Cluster.pm b/src/test/perl/PostgreSQL/Test/Cluster.pm > index 666bd2a2d4c..1c66360c16c 100644 > --- a/src/test/perl/PostgreSQL/Test/Cluster.pm > +++ b/src/test/perl/PostgreSQL/Test/Cluster.pm > @@ -3761,7 +3761,8 @@ sub checksum_enable_offline > my ($self) = @_; > > print "### Enabling checksums in \"$self->data_dir\"\n"; > - PostgreSQL::Test::Utils::system_or_bail('pg_checksums', '-D', $self->data_dir, '-e'); > + PostgreSQL::Test::Utils::system_or_bail('pg_checksums', '-D', > + $self->data_dir, '-e'); > return; > } This breaking between the command line options and its arguments is why we're switching to using fat commas. We're also using long options for improved self-documentation, so this should be written as: PostgreSQL::Test::Utils::system_or_bail('pg_checksums', '--pgdata' => $self->data_dir, '--enable'); And likewise below in the disable method. - ilmari