Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sWzmQ-000t1q-3C for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Jul 2024 14:49:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sWzmN-00FzlP-Lo for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Jul 2024 14:49:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sWzmM-00FzlH-D3 for pgsql-hackers@lists.postgresql.org; Thu, 25 Jul 2024 14:49:15 +0000 Received: from fhigh3-smtp.messagingengine.com ([103.168.172.154]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sWzmF-001OEH-4j for pgsql-hackers@postgresql.org; Thu, 25 Jul 2024 14:49:13 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 36371114005D; Thu, 25 Jul 2024 10:49:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 25 Jul 2024 10:49:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilmari.org; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1721918946; x=1722005346; bh=BytqVRlOmZlrFshDNWNLvY7NFfa1X7yfe2RJQTRykm8=; b= izf0gNiiGJQwihTQ7oMqiEih/05NflOjKTkxD+ZyKBtB6A/GSX8WcVBe7DZ+7NPo g+ECOEW3ZOOwqRVDiLwBCqlEFlz5deOzavUJKu9QN/6ZNFnhbgTEDfj0reywVuVx ezRjVnuXLDyAQ17M9bCpNbwJdf4EA3uAx7MNpiFAcfVwcrOW+Hds4cOCE+ubrXbT kWHFap2TYPU7CgdCw+yDFACfu1hU6Vmmr0VZKocOMBtwyh/xZm6By/oKDnIsUetC B1TenZbsn6a0O1qa78T+eUGEEWmlktoe+Lvf2X0CuvQ+WzxKpGEYzik2bD/JaaZJ u5kf3m5F48OWWZK6BRJJtQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1721918946; x= 1722005346; bh=BytqVRlOmZlrFshDNWNLvY7NFfa1X7yfe2RJQTRykm8=; b=F lFrBMl+uosvJVWydphE2dC/lQqxtza/HNVmuggPJELi3dJbTCGYieTTqyP2L7eTU T2JSolunvEDPJz7kbOVibls6Bd1BDvt5f4g/4GrsqoA7yGVr91IOpGc+uvzR+eWP Nv6cJEc/NixSEu9OnxjjgwhyHgKuzhi6YFmPT/YeTCal46Yfdk8pKXxst6R9vQu8 YT9IlFFfYM+jnAXtkbIFIVwBFgVl9yP1if7oO83mtJlaCo66MgZOT0iUC/9PoSF4 +6xQjIVaO9T0ru5uclYV+2Ri8ie5dWGAtvMLZlt8w6bJ33pdEkV1UrHd8GZBO+f7 DsNcqbOTcG4na/EqZNJSQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrieefgdektdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufhfffgjkfgfgggtgfesthekredttderjeenucfhrhhomhepffgrghhf ihhnnhcukfhlmhgrrhhiucforghnnhhsnohkvghruceoihhlmhgrrhhisehilhhmrghrih drohhrgheqnecuggftrfgrthhtvghrnhepfeehteetveeltdduueduffdvtdeuudejueet hefgleegtdeftdefleehkefgudfgnecuffhomhgrihhnpehpohhsthhgrhdrvghsnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihhlmhgrrhhi sehilhhmrghrihdrohhrghdpnhgspghrtghpthhtoheptd X-ME-Proxy: Feedback-ID: i1ff147bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 25 Jul 2024 10:49:05 -0400 (EDT) From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= To: Nathan Bossart Cc: px shi , pgsql-hackers@postgresql.org Subject: Re: CREATE MATERIALIZED VIEW References: <87cyn1eft4.fsf@wibble.ilmari.org> <87a5i5ef7e.fsf@wibble.ilmari.org> Date: Thu, 25 Jul 2024 15:49:02 +0100 In-Reply-To: (Nathan Bossart's message of "Thu, 25 Jul 2024 09:38:30 -0500") Message-ID: <877cd9edcx.fsf@wibble.ilmari.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Nathan Bossart writes: > On Thu, Jul 25, 2024 at 03:09:09PM +0100, Dagfinn Ilmari Mannsåker wrote: >> Scratch that, I misread the diff. The tab completion has been there >> since matviews were added in commit 3bf3ab8c5636, but the restriction on >> unlogged matviews was added later in commit 3223b25ff73, which failed to >> update the tab completion code to match. > > As noted a few years ago [0], the commit message for 3223b25ff73 indicates > this was intentional: > > I left the grammar and tab-completion support for CREATE UNLOGGED > MATERIALIZED VIEW in place, since it's harmless and allows delivering a > more specific error message about the unsupported feature. D'oh, I'm clearly struggling with reading things properly today. > However, since it looks like the feature was never actually supported in a > release, and the revert has been in place for over a decade, I think it'd > be reasonable to remove the tab completion now. It looks like the folks on > the 2021 thread felt similarly. Keeping it in the grammar makes sense for the more specific error message, but I don't think the tab completion should be suggesting bogus things, regardless of whether it's the grammar or the parse analysis that rejects it. > [0] https://postgr.es/m/flat/ZR0P278MB092093E92263DE16734208A5D2C59%40ZR0P278MB0920.CHEP278.PROD.OUTLOOK.COM - ilmari