Feedback-ID: i1ff147bf:Fastmail
From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
To: Christoph Berg <myon@debian.org>
Cc: Daniel Gustafsson <daniel@yesql.se>,  Peter Eisentraut
 <peter.eisentraut@enterprisedb.com>,  PostgreSQL Hackers
 <pgsql-hackers@lists.postgresql.org>
Subject: Re: plpgsql-trigger.html: Format TG_ variables as table (patch)
References: <Yw4Noe3A2s87A0qq@msg.df7cb.de>
	<357fec80-cb54-1455-0632-b23d844e5a68@enterprisedb.com>
	<Yw8xAZhbvlzJR3Jf@msg.df7cb.de> <Yw9MJ8/CPJ2bzi0Q@msg.df7cb.de>
	<AF7104E5-8B27-4C84-8771-63972396E957@yesql.se>
	<Yw9Rkn0UXvsIhACV@msg.df7cb.de> <Yw9VFHD1APjGRCec@msg.df7cb.de>
Date: Wed, 31 Aug 2022 15:19:50 +0100
In-Reply-To: <Yw9VFHD1APjGRCec@msg.df7cb.de> (Christoph Berg's message of
	"Wed, 31 Aug 2022 14:33:24 +0200")
Message-ID: <877d2omr5l.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/877d2omr5l.fsf%40wibble.ilmari.org>
Precedence: bulk

Christoph Berg <myon@debian.org> writes:

> Re: To Daniel Gustafsson
>> "string containing" is again pretty boilerplatish, how about just
>> "contains"?
>
> Actually, just omitting the whole prefix works best.
>
> TG_WHEN (text)
>
>     BEFORE, AFTER, or INSTEAD OF, depending on the trigger's definition.

The attached patch does not reflect this, did you attach an old version?

> I also shortened some "name of table" to just "table". Since the data
> type is "name", it's clear what "table" means.

I think it reads better with the definite article and initial capital,
e.g. "The table that triggered ….".

>     <variablelist>
>      <varlistentry>
> -     <term><varname>NEW</varname></term>
> +     <term><varname>NEW</varname> (record)</term>

The type names should still be wrapped in <type>, like they were before.

- ilmari