Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqHGo-00054z-8N for pgsql-hackers@arkaria.postgresql.org; Mon, 07 Jun 2021 15:34:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lqHGn-00031A-7X for pgsql-hackers@arkaria.postgresql.org; Mon, 07 Jun 2021 15:34:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqHGm-000312-W8 for pgsql-hackers@lists.postgresql.org; Mon, 07 Jun 2021 15:34:29 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqHGl-0007MA-20 for pgsql-hackers@postgresql.org; Mon, 07 Jun 2021 15:34:28 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 157FYOCQ878796; Mon, 7 Jun 2021 11:34:24 -0400 From: Tom Lane To: Peter Eisentraut cc: Jacob Champion , "pgsql-hackers@postgresql.org" Subject: Re: SSL SNI In-reply-to: <5df46438-c1b4-161c-4669-f6e6ab6797f0@enterprisedb.com> References: <7289d5eb-62a5-a732-c3b9-438cee2cb709@enterprisedb.com> <9407b344-7342-b2b7-004f-d5250687be42@enterprisedb.com> <4eaa2b56-c3d0-67b6-4716-010d001c7601@enterprisedb.com> <4bf3ae1c-b28e-8960-e89f-c390c5cf01a2@enterprisedb.com> <504c276ab6eee000bb23d571ea9b0ced4250774e.camel@vmware.com> <14368.1622742108@sss.pgh.pa.us> <14840.1622742761@sss.pgh.pa.us> <15936.1622744081@sss.pgh.pa.us> <5df46438-c1b4-161c-4669-f6e6ab6797f0@enterprisedb.com> Comments: In-reply-to Peter Eisentraut message dated "Mon, 07 Jun 2021 11:54:31 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <878794.1623080064.1@sss.pgh.pa.us> Date: Mon, 07 Jun 2021 11:34:24 -0400 Message-ID: <878795.1623080064@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Eisentraut writes: > Patch attached. Empty host string was handled implicitly by the IP > detection expression, but I added an explicit check for sanity. (I > wasn't actually able to get an empty string to this point, but it's > clearly better to be prepared for it.) Yeah, I'd include the empty-string test just because it's standard practice in this area of libpq. Whether those tests are actually triggerable in every case is obscure, but ... Patch looks sane by eyeball, though I didn't test it. regards, tom lane